Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix detection of 'empty' changelog sections #11

Open
amtep opened this issue Aug 4, 2022 · 1 comment
Open

Fix detection of 'empty' changelog sections #11

amtep opened this issue Aug 4, 2022 · 1 comment
Labels
O-Community

Comments

@amtep
Copy link
Contributor

amtep commented Aug 4, 2022

ci-actions/update-changelog/src/helpers.ts

Line 87 in 3f810b2

return content.includes("*") && !content.includes("* None\n");

I've noticed that many of realm-js changelog entries contains * None. rather than * None

I think this function should be updated to allow a period after None.
@nirinchev
Copy link
Member

Or we should fix realm-js to not have period after non-sentences 😜 Seriously though, I'm not opposed to this change - we can definitely make it less strict with a regex.

amtep added a commit to amtep/realm-js that referenced this issue Aug 4, 2022
@amtep
Use just "None" without a period in the changelog.
dfd1083 
See realm/ci-actions#11
The update-changelog action does not recognize "None." with a period.
amtep added a commit to amtep/realm-js that referenced this issue Aug 4, 2022
@amtep
Use just "None" without a period in the changelog.
6539b5e 
See realm/ci-actions#11
The update-changelog action does not recognize "None." with a period.
amtep added a commit to amtep/realm-js that referenced this issue Aug 9, 2022
@amtep
Use just "None" without a period in the changelog.
f5196c9 
See realm/ci-actions#11
The update-changelog action does not recognize "None." with a period.
amtep added a commit to amtep/ci-actions that referenced this issue Aug 16, 2022
@amtep
update-changelog: Detect * None. as well as * None for empty chan…
8467662 
…gelogs.

realm-js uses `* None.` by default.

Fixes realm#11

Compiled with Node.js 16
Node.js 17+ gives errors about openssl incompatibility.
amtep added a commit to amtep/ci-actions that referenced this issue Sep 20, 2022
@amtep
update-changelog: Detect * None. as well as * None for empty chan…
c704247 
…gelogs.

realm-js uses `* None.` by default.

Fixes realm#11

Compiled with Node.js 16
Node.js 17+ gives errors about openssl incompatibility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
O-Community
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amtep @nirinchev