Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input System Focus Provider implementation registers its own implementation instead of through configuration #32

Open
SimonDarksideJ opened this issue May 15, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@SimonDarksideJ
Copy link
Contributor

Reality Collective - Reality Toolkit Bug Report

Describe the bug

Currently, the Focus Provider is Registered manually by the Input System during instantiation (Constructor), which is not the correct behaviour as services "should" be registered through configuration alone.

As part of the Service Framework implementation, this caused issues because it was trying to register a data provider as it was being created but before it was registered, this caused the focus provider instantiation to fail because its parent service (the input system) was not actively registered yet.

This needs a better implementation whereby the focus provider is recognised in the configuration and instantiated along with other data providers once its parent system is active.

Expected behavior

Data Providers should be instantiated once their parent services are registered.

Actual behavior

The Focus data provider is trying to register before the input system, during the class instantiation of the Input System.

@SimonDarksideJ SimonDarksideJ added the bug Something isn't working label May 15, 2022
@SimonDarksideJ SimonDarksideJ self-assigned this May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant