Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add Interface validation on GetService calls to check if an interface is passed #37

Open
SimonDarksideJ opened this issue Dec 7, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@SimonDarksideJ
Copy link
Contributor

Currently the GetService / TryGetService calls on the service manager accept any type when querying for a service, however, only interfaces should be passed to query for registered services.

So if a concrete type is passed, the service obviously cannot be resolved as the framework is interface dependent, but the consumer is unaware of the issue and this can lead to confusion.

@SimonDarksideJ SimonDarksideJ added the enhancement New feature or request label Dec 7, 2022
@FejZa
Copy link
Contributor

FejZa commented Jan 8, 2024

I'd go even further. Only interface types that are based on IService should be passed and valid for those APIs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants