Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Node.js code examples as simple as possible #561

Open
2 tasks
domharrington opened this issue Aug 29, 2022 · 0 comments
Open
2 tasks

Make Node.js code examples as simple as possible #561

domharrington opened this issue Aug 29, 2022 · 0 comments
Labels
needs triage node Issues related to our Node SDK

Comments

@domharrington
Copy link
Member

domharrington commented Aug 29, 2022

After merging in #459, the hapi and fastify code samples have to have some non-obvious patches made to the request/response objects in order to make it work properly. These should be rolled into the core function to make these examples as simple as possible and move the complexity to the internals.

@erunion erunion added node Issues related to our Node SDK needs triage labels Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage node Issues related to our Node SDK
Projects
None yet
Development

No branches or pull requests

2 participants