Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve JSON Schema #8

Closed
7 tasks done
HadrienGardeur opened this issue Jul 25, 2018 · 4 comments
Closed
7 tasks done

Improve JSON Schema #8

HadrienGardeur opened this issue Jul 25, 2018 · 4 comments
Labels
enhancement

Comments

@HadrienGardeur
Copy link
Member

HadrienGardeur commented Jul 25, 2018 •
edited
Loading

Our first draft for our JSON Schema is missing the following things:

  • Validate the presence of at least one self link
  • Validate that templated is set to true when a URI template is used in a link object
  • Validate the presence of type for readingOrder and resources items
  • Validation for languages (in language maps or in language)
  • Validate extensibility based on collection model
  • Validation for properties
  • Validation for subject
HadrienGardeur pushed a commit that referenced this issue Jul 31, 2018
Added more validations in JSON Schema
53b930e 
related #8
Validates the presence of the templated flag for URI templates
Validates the presence of a media type in readingOrder and resources
HadrienGardeur pushed a commit that referenced this issue Jul 31, 2018
Added validation for self link
7de8aed 
related #8
@HadrienGardeur
Copy link
Member Author

For languages, I think that the best option is to validate against a regexp.

HadrienGardeur pushed a commit that referenced this issue Jul 31, 2018
Added language validation in JSON Schema
a15549b 
related #8
Added language validation, including on objects that use a language map
HadrienGardeur pushed a commit that referenced this issue Jul 31, 2018
Added a description for the language validation
b0e82af 
related #8
@HadrienGardeur
Copy link
Member Author

It's also unclear to me if for the self link this would be better expressed using dependencies.

This was referenced Dec 27, 2018
Closed
Open
Closed
Closed
@danielweck
Copy link
Member

danielweck commented Dec 27, 2018 •
edited
Loading

Related issues:
#13
#14
#15
#16
#17
#19

@danielweck danielweck mentioned this issue Dec 27, 2018
Closed
@danielweck
Copy link
Member

Possibly related: #18

@danielweck danielweck mentioned this issue Dec 28, 2018
Closed
@HadrienGardeur HadrienGardeur pinned this issue Jan 7, 2019
@HadrienGardeur HadrienGardeur unpinned this issue Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HadrienGardeur @danielweck