0.36.3

[rmorshea]

Misc bug fixes along with a minor improvement that allows components to return None
to render nothing.

Closed Issues

• All child states wiped upon any child key change - All child states wiped upon any child key change #652
• Allow NoneType returns within components - Allow NoneType and Iterable returns within components #538

Merged Pull Requests

• fix All child states wiped upon any child key change #652 - fix #652 #672
• Fix 663 - Fix 663 #667

---

This discussion was created from the release 0.36.3.

[Archmonger]

Thanks, I'll test this out soon!

[Archmonger]

@rmorshea This version is critically broken. Layout rendering is now completely non-functional on Conreq/app_store with no visible errors.

[rmorshea]

Now that I think about it, I think this should have been a 0.37.0 release.

[Archmonger]

I had my venv which was the latest django-idom, and then I manually did pip install idom --upgrade. That action bumped the IDOM version from 0.36.0 to 0.36.3.

[Archmonger]

I just confirmed a completely fresh venv has the same behavior. At least for me, 0.36.3 is critically broken.

[rmorshea]

Did you also bump the JS version?

[rmorshea]

I put up an MR to bump the JS dependency in idom-django

[Archmonger]

The child state issue is resolved. I also did a quick test of using the _ function as an alternative to top level divs, but this didn't work.

[rmorshea]

Hadn't thought about keys. Can you create an issue about supporting keys in fragments?

[Archmonger]

I don't know if you caught my comment edit, but I determined that html._ does not play nicely with things exported via module_from_template

[rmorshea]

And there's not client-side error of any kind?

Either way though, when you find time, if you can make a script that reproduces the issues above I'll try and debug it this coming week.

[Archmonger]

Nope, no client side error. I'll create a reproducible example now.

[Archmonger]

After some more testing I determined this was an issue on my side.

I should've inspected the DOM. Things are rendering. It failed previously due to some CSS that was made with the assumption of a top-level div. The BS modal created a div, which messed things up.

[Archmonger]

I've detected a new warning on console. I'm not sure how to reproduce. All I was doing was flipping through sidebar tabs.

Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup function.
    at ImportedElement (http://127.0.0.1:7575/static/django_idom/client.js:31116:28)
    at Element (http://127.0.0.1:7575/static/django_idom/client.js:31050:20)

Let me know if I should generate an issue.

[Archmonger]

@rmorshea Let me know if this console log means anything to you.

[rmorshea]

Ok, I think I know what's going on here. This wasn't introduced by this release, but it's a bug. I can try to write it up.

[rmorshea]

#690