Added validatePermissions for Surcharges query endpoints #6716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sujith <[email protected]>
🦋 Changeset detectedLatest commit: da3d8e9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Signed-off-by: Sujith <[email protected]>
brent-hoover
approved these changes
Jan 3, 2023
vanpho93
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sujith [email protected]
Resolves #6634
Impact: minor
Type: bugfix
Issue
As reported in issue #6634, Surcharges query endpoints were missing permission validation
Solution
Added validatePermissions call for both the queries [surcharges & surchargeById]
Breaking changes
If any user expected to have this permissions is not added to the required groups which has permission, will no longer be able to get results from these 2 queries unless added to the required groups.
Testing
Test caes added