Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor functions that collect quotes from various fulfillment methods #6821

Open
sujithvn opened this issue Mar 8, 2023 · 0 comments
Open

Refactor functions that collect quotes from various fulfillment methods #6821

sujithvn opened this issue Mar 8, 2023 · 0 comments
Assignees
@sujithvn
Labels
Fulfillment Types Allow products to fulfilled using flexible method such as download, store pickup, ettc

Comments

@sujithvn
Copy link
Contributor

sujithvn commented Mar 8, 2023

The current logic in api-plugin-fulfillment/src/queries/fulfillmentMethodsWithQuotes.js and the called functions in the fulfillment-method plugins (ex. api-plugin-fulfillment-method-pickup-store/src/fulfillmentMethodsWithQuotesPickupStore.js) may need to be refactored to avoid function mutating passed in parameters.

Also, there is a possible bug in case of retrials where the rates entries may get pushed to array again creating duplicates.

Refer: review comment form Brian
@sujithvn sujithvn added the Fulfillment Types Allow products to fulfilled using flexible method such as download, store pickup, ettc label Mar 8, 2023
@sujithvn sujithvn self-assigned this Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sujithvn sujithvn

Labels
Fulfillment Types Allow products to fulfilled using flexible method such as download, store pickup, ettc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sujithvn