From b5fd9cd9ac24927a12a1878bac206b2e997f9dca Mon Sep 17 00:00:00 2001 From: Machiko Yasuda Date: Wed, 19 Sep 2018 13:42:51 -0700 Subject: [PATCH 1/6] fix: fix hydra link --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 3d88c7a..b260505 100644 --- a/README.md +++ b/README.md @@ -45,4 +45,4 @@ Copyright © Reaction Commerce [ory/hydra][hydra] is licensed under [Apache License 2.0](https://github.com/ory/hydra/blob/master/LICENSE) -[hydra]: https://github/ory/hydra +[hydra]: https://github.com/ory/hydra From 2b0797d6ad2e820ca5d82dd42099b113575edaa8 Mon Sep 17 00:00:00 2001 From: Machiko Yasuda Date: Wed, 19 Sep 2018 13:45:00 -0700 Subject: [PATCH 2/6] chore: add code of conduct --- CODE_OF_CONDUCT.md | 38 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) create mode 100644 CODE_OF_CONDUCT.md diff --git a/CODE_OF_CONDUCT.md b/CODE_OF_CONDUCT.md new file mode 100644 index 0000000..63b7f2b --- /dev/null +++ b/CODE_OF_CONDUCT.md @@ -0,0 +1,38 @@ +# Reaction Commerce Code of Conduct + +All Community Guidelines content is licensed under a [Creative Commons Attribution](https://creativecommons.org/licenses/by/3.0/) license. + +Like the technical community as a whole, the Reaction team and community is made up of a mixture of professionals and volunteers from all over the world, working on every aspect of the mission - including mentorship, teaching, and connecting people. + +Diversity is one of our huge strengths, but it can also lead to communication issues and unhappiness. To that end, we have a few ground rules that we ask people to adhere to. This code applies equally to founders, mentors, and those seeking help and guidance. + +This isn’t an exhaustive list of things that you can’t do. Rather, take it in the spirit in which it’s intended - a guide to make it easier to enrich all of us and the broader communities in which we participate. + +This code of conduct applies to all spaces managed by Reaction Commerce. This includes our [development chat room](https://gitter.im/reactioncommerce/reaction), [forums](https://forums.reactioncommerce.com), [blog](https://blog.reactioncommerce.com), mailing lists, [issue tracker](https://github.com/reactioncommerce/reaction/issues), [project boards](https://github.com/reactioncommerce/reaction/projects), Reaction events and meetups, and any other forums or service created by the core project team which the community uses for communication. In addition, violations of this code outside these spaces may affect a person's ability to participate within them. + +If you believe someone is violating the code of conduct, we ask that you report it by emailing . For more details, please see our [Reporting Guidelines](https://docs.reactioncommerce.com/reaction-docs/master/reporting-guide). + +- **Be friendly and patient.** + +- **Be welcoming.** We strive to be a community that welcomes and supports people of all backgrounds and identities. This includes, but is not limited to members of any race, ethnicity, culture, national origin, color, immigration status, social and economic class, educational level, sex, sexual orientation, gender identity and expression, age, size, family status, political belief, religion, and mental and physical ability. + +- **Be considerate.** Your work will be used by other people, and you in turn will depend on the work of others. Any decision you take will affect users and colleagues, and you should take those consequences into account when making decisions. Remember that we're a world-wide community, so you might not be communicating in someone else's primary language. + +- **Be respectful.** Not all of us will agree all the time, but disagreement is no excuse for poor behavior and poor manners. We might all experience some frustration now and then, but we cannot allow that frustration to turn into a personal attack. It’s important to remember that a community where people feel uncomfortable or threatened is not a productive one. Members of the Reaction community should be respectful when dealing with other members as well as with people outside the Reaction community. + +- **Be careful in the words that you choose.** We are a community of professionals, and we conduct ourselves professionally. Be kind to others. Do not insult or put down other participants. Harassment and other exclusionary behavior aren't acceptable. This includes, but is not limited to: + + - Violent threats or language directed against another person. + - Discriminatory jokes and language. + - Posting sexually explicit or violent material. + - Posting (or threatening to post) other people's personally identifying information ("doxing"). + - Personal insults, especially those using racist or sexist terms. + - Unwelcome sexual attention. + - Advocating for, or encouraging, any of the above behavior. + - Repeated harassment of others. In general, if someone asks you to stop, then stop. + +- **When we disagree, try to understand why.** Disagreements, both social and technical, happen all the time and Reaction is no exception. It is important that we resolve disagreements and differing views constructively. Remember that we’re different. The strength of Reaction comes from its varied community, people from a wide range of backgrounds. Different people have different perspectives on issues. Being unable to understand why someone holds a viewpoint doesn’t mean that they’re wrong. Don’t forget that it is human to err and blaming each other doesn’t get us anywhere. Instead, focus on helping to resolve issues and learning from mistakes. + +## Questions? + +If you have questions, please see the [FAQs](https://docs.reactioncommerce.com/reaction-docs/master/guideline-faqs). If that doesn't answer your questions, feel free to [contact us](mailto:hello@reactioncommerce.com). From 932744a7e2defb6dec384fd5140e3cd35cdbc597 Mon Sep 17 00:00:00 2001 From: Machiko Yasuda Date: Wed, 19 Sep 2018 13:45:13 -0700 Subject: [PATCH 3/6] chore: add Contributing guide --- CONTRIBUTING.md | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) create mode 100644 CONTRIBUTING.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md new file mode 100644 index 0000000..915acf6 --- /dev/null +++ b/CONTRIBUTING.md @@ -0,0 +1,36 @@ +# Contributing + +At Reaction Commerce, we're dedicated to the open source community. In fact, we've designed our entire platform and business to grow from the passion and creativity that an open source community ignites. We've already attracted a small, dedicated team of open source contributors, and there's always room for more. If you'd like to join us, here's how to get started: + +**Step 1:** If you haven't already, get Reaction running locally: + +```sh +curl https://install.meteor.com | /bin/sh +git clone https://github.com/reactioncommerce/reaction.git +cd reaction +reaction +``` + +**Step 2:** + +Explore the interface and the code to give you a good overview of the product and a sense for what's already built. Keep an eye out for bugs and interface issues, as well as features you'd like to see created. + +**Step 3:** + +Explore the [GitHub issues already open on our main repo](https://github.com/reactioncommerce/reaction/issues) and our [GitHub project boards](https://github.com/reactioncommerce/reaction/projects). If you find something you want to work on, let us know right there in the comments. [`Pull Requests Encouraged`](https://github.com/reactioncommerce/reaction/issues?q=is%3Aissue+is%3Aopen+label%3Apull-requests-encouraged) and [`Verified Reproducible`](https://github.com/reactioncommerce/reaction/issues?q=is%3Aopen+is%3Aissue+label%3Averified-reproducible) labeled issues are a great place to start. + +If you are interested in a specific aspect of the project but aren't sure where to begin, feel free to ask. Start small and open up a dialogue with us. This will help to get your contributions accepted easily. + +**Step 4:** + +Let us know how we can make the contribution process easier. We want to find the best ways to support you. + +## Pull Requests + +[Create a pull request](https://help.github.com/articles/creating-a-pull-request/) to propose and collaborate on changes to Reaction. These changes are proposed in a PR branch, and are reviewed before merge acceptance into `master` for release. + +- Should reference an issue if one exists, or provide detailed information on the goal of the PR. +- Pass both [acceptance tests and unit testing](https://docs.reactioncommerce.com/reaction-docs/master/testing-reaction). New functionality should include new tests. +- Lint and adhere to the [Reaction style guide](https://docs.reactioncommerce.com/reaction-docs/master/styleguide). +- Contributors should review the CLA. +- Code reviewed before merge acceptance. From 31d4b29f6f87a8568cf6e263e58edf5a1d13ebb2 Mon Sep 17 00:00:00 2001 From: Machiko Yasuda Date: Wed, 19 Sep 2018 13:46:06 -0700 Subject: [PATCH 4/6] chore: add pull request, issue templates --- .github/ISSUE_TEMPLATE/bug_report.md | 37 +++++++++++++++++++++++ .github/ISSUE_TEMPLATE/feature_request.md | 14 +++++++++ .github/pull_request_template.md | 26 ++++++++++++++++ 3 files changed, 77 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/bug_report.md create mode 100644 .github/ISSUE_TEMPLATE/feature_request.md create mode 100644 .github/pull_request_template.md diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md new file mode 100644 index 0000000..b730fc7 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -0,0 +1,37 @@ +--- +name: Bug report +about: Create a report to help us improve + +--- + +Type: **breaking|critical|major|minor** + +**Describe the bug** +A clear and concise description of what the bug is. + +**To Reproduce** +Steps to reproduce the behavior: +1. Go to '...' +2. Click on '....' +3. Scroll down to '....' +4. See error + +**Expected behavior** +A clear and concise description of what you expected to happen. + +**Screenshots** +If applicable, add screenshots to help explain your problem. + +**Desktop (please complete the following information):** + - OS: [e.g. iOS] + - Browser [e.g. chrome, safari] + - Version [e.g. 22] + +**Smartphone (please complete the following information):** + - Device: [e.g. iPhone6] + - OS: [e.g. iOS8.1] + - Browser [e.g. stock browser, safari] + - Version [e.g. 22] + +**Additional context** +Add any other context about the problem here. diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md new file mode 100644 index 0000000..94a5246 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -0,0 +1,14 @@ +--- +name: Feature request +about: Suggest a new feature for this project + +--- + +# Feature Name + +### Summary description + +### Rationale for why this feature is necessary + +### Expected use cases + diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 0000000..e36c2e4 --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,26 @@ +Resolves #issueNumber +Impact: **breaking|critical|major|minor** +Type: **feature|bugfix|performance|test|style|refactor|docs|chore** + +## Issue +Description of the issue this PR is solving, why it's happening, and how to reproduce it. This may differ from the original ticket as you now have more information at your disposal. + +## Solution +Summarize your solution to the problem. Please include short descriptions of any solutions you tested before arriving at your final solution. This will help reviewers know why you decided to solve this problem in this particular way and will speed up the review process. + +If you're solving a UIX related issue, please attach screen-caps or gifs showing how your solution differs from the issue. + +## Breaking changes +If you have a breaking changes, list them here, otherwise list none. + +Examples of breaking changes include changing file names, moving files, deleting files, renaming functions or exports, or changes to code which might cause previous versions of Reaction or third-party code not to work as expected. + +Note any work that you did to mitigate the effect of any breaking changes such as creating migrations, deprecation warnings, etc. + + +## Testing +1. List the steps needed for testing your change in this section. +2. Assume that testers already know how to start the app, and do the basic setup tasks. +3. Be detailed enough that someone can work through it without being too granular + +More detail for what each of these sections should include are available in our [Contributing Docs](https://docs.reactioncommerce.com/reaction-docs/master/contributing-to-reaction) From 4d8edf8a9e02a1170fa1d727b2e45974ce25cec0 Mon Sep 17 00:00:00 2001 From: Machiko Yasuda Date: Wed, 19 Sep 2018 13:47:04 -0700 Subject: [PATCH 5/6] fix: typo --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index b260505..26887c5 100644 --- a/README.md +++ b/README.md @@ -7,7 +7,7 @@ Ready for Reaction development. ### Part of the Reaction Platform This application is a part of the Reaction Platform and is designed to work -with other services. You can launch Reaction and it's dependencies with a +with other services. You can launch Reaction and its dependencies with a single command by using the [Reaction Platform][reaction-platform] development installation. From 701518e86c0b1fad0ee1b5312cdd28e30ce6ed33 Mon Sep 17 00:00:00 2001 From: machiko Date: Thu, 20 Sep 2018 15:42:35 -0700 Subject: [PATCH 6/6] chore: change version/os section --- .github/ISSUE_TEMPLATE/bug_report.md | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index b730fc7..c5ad6e6 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -19,19 +19,10 @@ Steps to reproduce the behavior: **Expected behavior** A clear and concise description of what you expected to happen. -**Screenshots** -If applicable, add screenshots to help explain your problem. - -**Desktop (please complete the following information):** - - OS: [e.g. iOS] - - Browser [e.g. chrome, safari] - - Version [e.g. 22] - -**Smartphone (please complete the following information):** - - Device: [e.g. iPhone6] - - OS: [e.g. iOS8.1] - - Browser [e.g. stock browser, safari] - - Version [e.g. 22] +**Version** + - OS: [e.g. OS X] + - Version of Reaction [e.g. 2.0.0] + - Version of Hydra **Additional context** Add any other context about the problem here.