Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promotions: Notifications or alerts about jobs that may be processing #180

Open
node82 opened this issue Jan 31, 2023 · 3 comments
Open
Labels
enhancement New feature or request Promotions

Comments

@node82
Copy link

node82 commented Jan 31, 2023

When a Promotion is enabled, it takes a little while to show as Active
it does show in the upcoming tab as enabled but does take awhile before showing in the active tab with no indication that anything is processing.

it shows once a batch job is performed:
(reaction api)
INFO @reactioncommerce/api-plugin-promotions: Completed processing batch of cart promotion checks (totalModified=0, totalUnchanged=1, numberOfCarts=1, version=0.0.0, file=checkCartForPromotionChange.js)

it may be helpful to communicate on the front end kinetic UX to the operator that it is processing. Like an alert, or status notification that a job is processing , has an error, and or has completed.

@brent-hoover
Copy link
Collaborator

@node82 I think the idea here is that normally you are creating promotions before the time not enabling them in real time. Is this an actual use case of creating a promotion that needs to be enabled in real time?

@vannguyenn @vanpho93 any ideas on an easy way to implement this?

@brent-hoover brent-hoover added enhancement New feature or request Promotions labels Feb 3, 2023
@vannguyenn
Copy link
Collaborator

If I understand correctly, we want KInetic to show the jobs running on the server related to the Promotions. I think firstly we need to create an API endpoint to check if there is any running process and then use polling or websocket to request the API endpoint to show the alert on the client (Kinetic)

@node82
Copy link
Author

node82 commented Feb 8, 2023

that is true. in most cases you would set them up in advance, and schedule them for a later date.
it was just the experience when pushing a promotion live intraday, or on short scheduled notice, which does occur from time to time, if i recall maybe once or twice a month depending upon the promotion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Promotions
Projects
None yet
Development

No branches or pull requests

3 participants