Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review link styles #577

Closed
adamkudrna opened this issue Nov 27, 2024 · 0 comments · Fixed by #580
Closed

Review link styles #577

adamkudrna opened this issue Nov 27, 2024 · 0 comments · Fixed by #580
Labels
accessibility BC Breaking change
Milestone
v1.0.0

Comments

@adamkudrna
Copy link
Member

Ideas:

  1. use regular font weight for links in Alerts
  2. underline links by default so they are distinguishable from regular text in neutral Cards
@adamkudrna adamkudrna converted this from a draft issue Nov 27, 2024
@adamkudrna adamkudrna assigned adamkudrna and unassigned adamkudrna Nov 27, 2024
@adamkudrna adamkudrna added BC Breaking change accessibility labels Nov 27, 2024
@adamkudrna adamkudrna added this to the v1.0.0 milestone Nov 27, 2024
@adamkudrna adamkudrna mentioned this issue Nov 27, 2024
Merged
@adamkudrna adamkudrna moved this from 🔖 To do to 🏗 In progress in The Board Dec 2, 2024
adamkudrna added a commit that referenced this issue Dec 2, 2024
@adamkudrna
Allow configuration of font weight of links inside Alert #577
78aacd9 
Default font weight of links is now set to "regular" so it is
consistent with other links in React UI. However, it remains
configurable because of downstream project requirements.
adamkudrna added a commit that referenced this issue Dec 2, 2024
@adamkudrna
Make text links underlined by default #577
2d506c6 
Since the color inheritance for links has been introduced
in #492, links in e.g. validation messages cannot be
distinguished from regular text until hovered. We chose
to underline all text links by default to make those links
discoverable by users.
@adamkudrna adamkudrna mentioned this issue Dec 2, 2024
Merged
adamkudrna added a commit that referenced this issue Dec 6, 2024
@adamkudrna
Remove configurable font weight of links inside Alert #577
2b323a2 
Links in `Alert` now inherit the font weight which is consistent
with other links in React UI.
adamkudrna added a commit that referenced this issue Dec 6, 2024
@adamkudrna
Make text links underlined by default #577
d8b0e6a 
Since the color inheritance for links has been introduced
in #492, links in e.g. validation messages cannot be
distinguished from regular text until hovered. We chose
to underline all text links by default to make those links
discoverable by users.
@adamkudrna adamkudrna linked a pull request Dec 6, 2024 that will close this issue
Make text links underlined by default #577 #580
Merged
@adamkudrna adamkudrna moved this from 🏗 In progress to 👀 In review in The Board Dec 6, 2024
adamkudrna added a commit that referenced this issue Dec 6, 2024
@adamkudrna
Remove configurable font weight of links inside Alert #577
72081fa 
Links in `Alert` now inherit the font weight which is consistent
with other links in React UI.
adamkudrna added a commit that referenced this issue Dec 6, 2024
@adamkudrna
Make text links underlined by default #577
e9f92dd 
Since the color inheritance for links has been introduced
in #492, links in e.g. validation messages cannot be
distinguished from regular text until hovered. We chose
to underline all text links by default to make those links
discoverable by users.
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in The Board Dec 6, 2024
adamkudrna added a commit that referenced this issue Dec 6, 2024
@adamkudrna
Remove configurable font weight of links inside Alert #577
6e6b321 
Links in `Alert` now inherit the font weight which is consistent
with other links in React UI.
adamkudrna added a commit that referenced this issue Dec 6, 2024
@adamkudrna
Make text links underlined by default #577
d3264dd 
Since the color inheritance for links has been introduced
in #492, links in e.g. validation messages cannot be
distinguished from regular text until hovered. We chose
to underline all text links by default to make those links
discoverable by users.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility BC Breaking change
Projects
The Board
Status: ✅ Done
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Make text links underlined by default #577 react-ui-org/react-ui
1 participant
@adamkudrna