Align cli version number with version number in cli docker image tag

[aeyaey]

It's is a bit confusing that the version number in the tag of the cli docker image isn't aligned with the cli version reported with yuniql version.

docker run --rm yuniql/cli:linux-x64-1.3.10 version

gives the following result:

yuniql 1.0.0

I would expect it to be yuniql 1.3.10.

The cli version reported is the assembly version of the underlying cli tool (from yuniql-cli/Yuniql.CLI.csproj) and it hasn't changed since it was introduced.

I know that the image tag version could contain a separate versioning, but it is still confusing for the user.

[rdagumampan]

@aeyaey thanks for reporting this issue. Yes, the docker version still got many bugs. This issue is caused by the fact the I have to run its own build inside docker different from the release pipeline that is shared by all other yuniql distributions.

The CLI version is self contained with all dependencies, so in many ways its as good as docker. Of course running on Linux agents are much better with Docker. Hope to find time to sort this issue. HTH

[rasmusskovdk]

@aeyaey thanks for reporting this issue. Yes, the docker version still got many bugs. This issue is caused by the fact the I have to run its own build inside docker different from the release pipeline that is shared by all other yuniql distributions.

One could consider setting the Version property when building/publishing. Either on the command line or use a environment variable with some env substitution in the csproj file. Are you interested in a pr?

I can't seem find any code related to distribution process of the yuniql docker image (except for the dockerfile). Shouldn't image building (and publishing to docker hub) ideally be covered by a github action (or other automatic ci/cd tool) that could respond to github releases? Should I create an issue for this, and perhaps give it a shot with a pr.

The CLI version is self contained with all dependencies, so in many ways its as good as docker. Of course running on Linux agents are much better with Docker. Hope to find time to sort this issue. HTH

I don't understand your distinction between 'CLI version' and 'docker' here.

From my viewpoint I think that in the best of all worlds any (github) release of yuniql would have:

• AssemblyVersion of all included yuniql assemblies set to the github release tag
• Docker images with tags matching the github release tag (containing assemblies with matching AssemblyVersions)
• NuGet packages with NuGet versions matching the github release tag (containing assemblies with matching AssemblyVersions)