-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing captioned.js file inside node module react-awesome-slider #172
Comments
Hello. You might want to refer to issue #165. By default package doesn't contain captioned.js. I understand it that way that it's only example how you can extend slider so it was made only for example purposes and those dependencies from example fit example project :D |
Thanks! I will try that then! |
It seems like i have to import more than just the captioned.js, by a lot of the files inside the folder. Any simple way to use the caption feature ? |
From what I've checked, only helpers section(examples.js) would need additional file import to make captioned.js work. Everything else is included in the ras package. I would suggest to include example.js with captioned.js manually in node_modules just to check if slider implementation is working fine and if it does, in the next step I would remove them and define captioned.js implementation inside project putting examples.js used content inside captioned.js single file as e.g. "rasCustomCaptioned.js" and reference it instead of captioned.js(which anyways isn't available in the package). I'm assuming that the rest of the imports will be recognized as from "node_modules". If not I would try modifying these paths to reference them. 30.03 - updated comment to be more detailed |
Hello there,
I'm trying to add some content to each of my sliders (that has an image already).
According to the documentation, I have to use Captioned HOC. But when I import all the needed files like so:
import AwesomeSlider from 'react-awesome-slider'; import withCaption from 'react-awesome-slider/dist/captioned'; import 'react-awesome-slider/dist/styles.css'; import 'react-awesome-slider/dist/captioned.css';
I'm running into an issue, it can't find the captioned file. You can see on these pictures that i have react-awesome-slider into my package.json file, but inside the node module, i only have the captioned.css files...
I have tried to reinstall the node module, changed of version, but got nothing different in return.
Anyone have got an idea about this issue ?
Thanks by advance and have a good day.
Beside that, great job for this module, it seems like an awesome library!! :D
The text was updated successfully, but these errors were encountered: