Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Ray Java code with Bazel. #4273

Closed
robertnishihara opened this issue Mar 5, 2019 · 4 comments
Closed

Build Ray Java code with Bazel. #4273

robertnishihara opened this issue Mar 5, 2019 · 4 comments

Comments

@robertnishihara
Copy link
Collaborator

Currently it still uses cmake. Related to #2887. Some work was done on this in #3918.
@robertnishihara robertnishihara mentioned this issue Mar 5, 2019
Closed
@robertnishihara
Copy link
Collaborator Author

@guoyuhong What still needs to be done here? It'd be great to deprecate cmake as quickly as possible.

@jovany-wang
Copy link
Contributor

We are working on this right now. I believe that it'll be met soon.

@pcmoritz
Copy link
Contributor

pcmoritz commented Mar 6, 2019 •
edited
Loading

Great, let's also make sure that ray can still compile if the java development environment is not installed, i.e. there should be a flag to deactivate it, or it should be a separate target, or it should only be compiled if the java development headers are available.

@jovany-wang
Copy link
Contributor

@pcmoritz
Building java code is in another target:

  1. build C++ part: ./build.sh -l java
  2. build Java part: bazel build //java:all

So i think it has no effect on anything now.

@ruifangChen ruifangChen mentioned this issue Mar 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pcmoritz @robertnishihara @jovany-wang