Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC for zarr support - DO NOT MERGE #91

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

JSKenyon
Copy link
Collaborator

  • Tests added / passed
  • Fully documented, including HISTORY.rst for all changes
    and one of the docs/*-api.rst files for new API
Howto run test cases and lint the code base
$ py.test --flake8 -v -s tricolour

If you encounter flake8 failures, a quick way to correct
this is to run autopep8 and flake8 again.

$ pip install -U autopep8
$ autopep8 -r -i tricolour
$ flake8 tricolour
Howto build the documentation

To build the docs locally:

$ pip install -r requirements.readthedocs.txt
$ cd docs
$ READTHEDOCS=True make html

This PR replaces xds_from_ms, xds_from_table and xds_to_table with their xds_to/from_storage_* equivalents. As part of this change I had to unpin basically all the dependencies i.e. this is not safe to merge. The reason for this change is to establish whether we can use Tricolour on AWS using zarr backed data in s3.

This runs through on a toy example on my laptop but there are still some sharp edges. The most important of these is that once a dataset has been converted to zarr, we no longer have the ability to reorder it via TAQL i.e. for now we will assume that any conversion will result in time-ordered data. This could be improved but shouldn't be necessary for POC experiments.

@JSKenyon JSKenyon marked this pull request as draft October 18, 2023 12:07
@ratt-priv-ci
Copy link
Collaborator

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants