Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 1.6.2 Beta #144

Draft
wants to merge 92 commits into
base: master
Choose a base branch
from
Draft

Version 1.6.2 Beta #144

wants to merge 92 commits into from

Conversation

razman786
Copy link
Collaborator

@razman786 razman786 commented Jun 8, 2022 •
edited
Loading

Draft PR for version 1.6.2

@o-smirnov, @bennahugo and @SpheMakh - please provide feedback on the new ALT+LeftButton profile selection feature, as this will be a building block towards #138

Closes #139, #140 and #141

  • Version bump in preparation for release
  • Adds selected profile feature (ALT+LeftButton)
  • WCS projection is now optimised for multiple images
  • WCS projection provides 2 modes, switchable via the new WCS Projection menu
  • Adds FITS header and WCS projection viewer
  • Coordinate measurements have been fixed
  • Fixes plot layout handling
  • Fixes dockable widget sizing and placement
  • Fixes historgram mouse wheel movement
  • Fixes issue Live profile mouse interaction feature #139 - Live and selected profiles
  • Fixes issue Update projection and interpolation handling code #140 - WCS projection
  • Fixes issue Fix flake8 errors #141 - flake8 errors
  • Various other minor refactorings and adjustments

N.B. There are a number of changes in this version.

razman786 added 30 commits June 1, 2022 12:16
@razman786
Converted old coordinate output to f-strings for better readability.
fbf78a4
@razman786
Fixes issue #140 - Fix projection handling
17f9f3d
@razman786
Unified coordinate output for merasure point and ruler to the GUI; 00…
34cb1fd 
…h00m00s

instead of 0h00m00s
@razman786
Fix input prarameters and reuse native frame format for reference coo…
2d2bdef 
…rdinate
@razman786
Fix WCS projection when unloading an image
4e23ad0
@razman786
Refactored optimise_wcs_projection. Fixed projection for computed ima…
a4e5789 
…ges.
@razman786
Fixes issue #140 - Fix projection handling
37d28b0
@razman786
Squash commit messages
179a7e2
@razman786
Fixes issue #140 - Added fallback method for calculating measurements.
fce5964 
Removed redundant measurement code.
@razman786
Fixes issue #141 - flake8 errors, refactoring and a tidy
8f1fd43
@razman786
Fixes issue #140 - Added a basic image information viewer that shows …
ad6f5ab 
…the FITS Header and plot's WCS projection
@razman786
Merge branch 'issue-133' into beta_162
0295ed8
@razman786
Merge branch 'issue-141' into beta_162
286f124
@razman786
Fixes issue #139 - Live profile mouse interaction feature and subsequ…
26d80dc 
…ent dockable widget fixes.
@razman786
Fixes issue #139 - Live profile mouse interaction feature and subsequ…
9e1f28a 
…ent dockable widget fixes.
@razman786
Merge branch 'beta_162' of github.com:ratt-ru/tigger into beta_162
ee12cc0
@razman786
Fixed widget resizing.
42a0740
@razman786
Removed WCS viewer shortcut key
ca1979d
@razman786
Removed redundant code
3841046
@razman786
Fix zoomed signal
bafeda1
@razman786
Fixed formatting
7d0fa3e
@razman786
Fixes issue #139 - Selected profiles are activated with Alt+Click
21a162d
@razman786
Fixed dock widget to dockarea invalid warning
3e83f0f
@razman786
Fixes issue #139 - Added GUI markup on plot for selected profile
f2fe0c3
@razman786
Adjusted the LiveImageZoom plot, SkyPlot and groups tab to have new c…
184b334 
…onstraints for their layouts.
@razman786
Added ALT+LeftButton help to 'Quick mouse reference'
398ad44
@razman786
Fixes issue #140 - Added WCS projection toggle menu item
51d9aad
@razman786
Refactored dockable widget handling when toggled or closed
417cbd7
@razman786
Fixed image control and right dock area sizing
c2ca6e2
@razman786
Updated CHANGELOG.rst for version 1.6.2
b667331
@bennahugo
Copy link
Collaborator

Should this be formally reviewed - I see it is marked draft. I've done a wee bit of local testing last week and it looks well behaved. Haven't tested it with multiple mosaic pointings as of yet. Let me know when I should start that

@razman786
Copy link
Collaborator Author

Should this be formally reviewed - I see it is marked draft. I've done a wee bit of local testing last week and it looks well behaved. Haven't tested it with multiple mosaic pointings as of yet. Let me know when I should start that

I left it as a draft for a few reasons:

  1. The WCS projection of multiple images needs checking (and measurements), along with the use of the new 'mean centre reference coordinate' (personally I like it, but that's just me). N.B. It may flag an error with some combos of images, but this seems to be an issue raised from reproject - yet to be solved in those corner cases (I suspect some wrapping somewhere, or something I have overlooked, or it is simply a limitation).
  2. The workflow of selecting profiles (with ALT+LeftButton) needs comment. Does it meet the issues spec correctly for selecting a single spectra? Ultimately, this becomes the base for tracking multiple spectra, so I want to know if this is OK before going further.
  3. I have seen a small bug that seems to present itself every now and then with multiple images loaded and taking measurements. Seems like (although I haven't had a moment to get to the bottom of it) the extents used in the main plotting, cut off a corner of the image projection in-line with the grid circles being drawn (i.e. when an image is in the bottom left quadrant), so some measurements are incorrect in this corner case, notability so.

Basically, I need comment on these 3 items to get it ready for review. Any help is much appreciated! \o/

This was linked to issues Jun 24, 2022
Update projection and interpolation handling code #140
Open
Fix flake8 errors #141
Open
@bennahugo
Copy link
Collaborator

Looks good as discussed -- the biggest issue we need another button for alt click -- does not work out of the box with KDE, as it is the combo to move windows.... Perhaps we should just make this click when the fixed profile is active?

bennahugo and others added 20 commits July 15, 2022 18:29
@bennahugo
Use ctrlalt+click for profile position selection
8a70834
@bennahugo
Basic multiple fixed profile support
b5b9885
@bennahugo
[wip] handle profile close/hide events
1de02a2
@bennahugo
Fix closing and toggling of the profile windows
30d4cfd
@bennahugo
fixes #148
f1fb3a1
@bennahugo
Fix divide by zero errors if minimum on axis is exactly 0
ec15163
@bennahugo
Add menu for selected profiles, add clearing option
9a79e9f
@bennahugo
add named profiles
403020c
@bennahugo
Add save freezed profile option
9a003e4
@bennahugo
Fix error messages in save profile
56c423c
@bennahugo
Add profile name to saved profile
91bed33
@bennahugo
Move profiles to loader class
bda0d14
@bennahugo
[WIP] Change v1 TigProf format to JSON, add loader
1051693 
- Adds TigProf loader
- Change underlying file format to json for simplicity
- TODO: need to still add QWT display profile curves and clearing
@razman786
Updated formatting
1a43c68
@razman786
Updated dockable name menu checking
6144214
@bennahugo
Working overlay static profiles
46e714e 
- added loading TigProf static profile from disk
- added pasting staticf profile from another profile
- Ensure moving active selected profile between images resets axis combobox
@bennahugo
Fix dock window close buttons
a2fb6ba
@bennahugo
[wip] add markers for static pasted profiles
d300c58
@bennahugo
Working overlay plot markers
8cfcf07
@bennahugo
Merge pull request #147 from ratt-ru/beta_162_with_multiprofiles
4fa0a4a 
Beta 162 with multiprofiles
@bennahugo
Copy link
Collaborator

bennahugo commented Jul 26, 2022 •
edited
Loading

@o-smirnov @IanHeywood ok I'm reasonably happy with my addition to the static "freezed" selected profile mechanism now. Please review.
We now have something like this (toggled by F4):
image
Features

  • As many individual selected profiles as you want
  • Saving / restoring to and from disk through a "TigProf" file
  • Overlays (to your choice of colour) such as
    image

(profile names/colour can be set arbitrarily)

Currently I only overlay static profiles (very similar to DS9 in other words with its copy and paste functionality). I was thinking of adding dynamically linked profiles where if you overlay profile a from profile b and you update profile a the overlay is also updated. However, I think as a first stab at this a static overlay for comparison is probably already good enough?

The only other feature that Oleg requested is H and V lines through the image if you have a selected profile on X or Y.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.2
3 participants
@razman786 @ratt-priv-ci @bennahugo