Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cpu_count over sched_getaffinity #110

Merged
merged 4 commits into from
May 31, 2023
Merged

Conversation

AlecThomson
Copy link
Contributor

Fixes #109

Fix for non-nix systems
Don't need len
@o-smirnov
Copy link
Collaborator

Thanks @AlecThomson! Could you please merge the latest master into your branch so we can re-test?

@AlecThomson
Copy link
Contributor Author

Sorry for the delay @o-smirnov ! Now done

@o-smirnov
Copy link
Collaborator

Damn something failing in dask now -- I suspect we may need to pin a version. @sjperkins could you take a look please?

@o-smirnov
Copy link
Collaborator

Actually looks like this problem: #111 (comment)

@Athanaseus
Copy link
Member

Also, further dependency pinning and resolution are addressed here: #112

@Athanaseus
Copy link
Member

@AlecThomson syncing this with master should resolve the failure.

@AlecThomson
Copy link
Contributor Author

@Athanaseus I think that worked!

Copy link
Member

@Athanaseus Athanaseus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@o-smirnov o-smirnov merged commit 07910cf into ratt-ru:master May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

os.sched_getaffinity is only available on Linux
3 participants