-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MultiSPW - Should all channels in a band have the same SPW #120
Comments
I seem to have broken the frequency<->band mapping in the multiple SPW case. I will attempt a fix shortly |
I made a slight adjustment to your strategy above to allow imaging multiple measurement sets with different frequency coverages together. This will go into main in #117 when the tests pass. With #121 this should allow you to redo your experiments on the VLA data we were looking at. Would appreciate if you could test drive it when you have a chance @y-mhiri |
I tried to image on the VLA data after the merge and everything went smoothly, no errors. I get an image that strongly what I got back then. Now I'm going to reproduce the results I got using l2reweight. |
Great, thanks for confirming @y-mhiri. Please close this issue when you consider it resolved |
The freq_mapping divide the channels in multiple bands according to the channels-per-integration option but no division according to the SPW is done. When cpi is fixed to -1, there is only one band that results from the frequency mapping in which all the SPW's are. It results in an error in the grid worker in the image_data_products() call in which all frequency channels should be the same accross the band (gridder.py l.380).
A simple fix a tried is to use the ddids to create the band along the SPW :
The text was updated successfully, but these errors were encountered: