Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC spinning off a process to compute parallactic angles #266

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sjperkins
Copy link
Member

  • Tests added / passed

    $ py.test -v -s africanus

    If the pep8 tests fail, the quickest way to correct
    this is to run autopep8 and then flake8 and
    pycodestyle to fix the remaining issues.

    $ pip install -U autopep8 flake8 pycodestyle
    $ autopep8 -r -i africanus
    $ flake8 africanus
    $ pycodestyle africanus
    
  • Fully documented, including HISTORY.rst for all changes
    and one of the docs/*-api.rst files for new API

    To build the docs locally:

    pip install -r requirements.readthedocs.txt
    cd docs
    READTHEDOCS=True make html
    

@sjperkins
Copy link
Member Author

This is not a complete solution, but exists to show that it's possible to spawn process for parangle computation and thereby avoid the GIL

@sjperkins sjperkins added the wip Work in progress label Jan 27, 2022
@sjperkins sjperkins marked this pull request as draft January 27, 2022 11:40
@sjperkins sjperkins changed the title Experiment with spinning off a process when computing parallactic angles POC spinning off a process to compute parallactic angles Jan 27, 2022
@sjperkins
Copy link
Member Author

My initial thoughts on a more complete solution would be a ProcessPoolExecutor associated with a RimeFactory, which would be available for use by RIME terms..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wip Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using casacore measures for computing parallactic angles acquires/drops the GIL excessively
2 participants