Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phase-only solver crashes in apply-only mode because of missing model #391

Open
o-smirnov opened this issue Jul 9, 2020 · 0 comments
Open
Assignees
Labels

Comments

@o-smirnov
Copy link
Collaborator

In apply-only mode, precompute_attributes is called here: https://github.com/ratt-ru/CubiCal/blob/master/cubical/solver.py#L615

(This was added to enable gain flagging in apply mode, IIRC.)

Unfortunately, the phase-only (and slope?) solver wants to have a model in precompute_attributes, so that it can precompute the constant parts of the Hessian. This causes it to crash in apply-only mode. SOP has been to use complex-2x2 in apply-only mode (since the gain tables are compatible), so we never noticed the problem.

The solution is to fix the phase-only solver to skip the Hessian precomputation if a model is not supplied.

@o-smirnov o-smirnov added the bug label Jul 9, 2020
@o-smirnov o-smirnov self-assigned this Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant