Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add release image signing guidance #129

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions docs/troubleshoot/security.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Refer to vulerability management and release documentation [here](https://github

## Signature Validation

Ratify signs all dev images and dev helm OCI artifacts with Notary Project and Sigstore Cosign signatures. Ratify will support signing release images in the near future.
Ratify signs all release images, dev images, and dev helm OCI artifacts with Notary Project and Sigstore Cosign signatures.

### Verifying Notary Project Signature

Expand All @@ -24,6 +24,9 @@ cat <<EOF > ./trustpolicy.json
{
"name": "ratify-images",
"registryScopes": [
"ghcr.io/ratify-project/ratify",
"ghcr.io/ratify-project/ratify-base",
"ghcr.io/ratify-project/ratify-crds",
"ghcr.io/ratify-project/ratify-dev",
"ghcr.io/ratify-project/ratify-base-dev",
"ghcr.io/ratify-project/ratify-crds-dev",
Expand All @@ -41,11 +44,11 @@ cat <<EOF > ./trustpolicy.json
}
EOF
notation policy import ./trustpolicy.json
notation verify ghcr.io/ratify-project/ratify:v1.4.0
Copy link
Contributor

@junczhu junczhu Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious about that, since v1.4.0 is not released shall we go with the latest version v1.3.1 instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking that updates to the docs here are for the next version on the website, which corresponds to unreleased changes. The current v1.3.1 release is not signed so we don't want to give that as an example. When v1.4.0 is released, the published release images will be signed and match the docs.

notation verify ghcr.io/ratify-project/ratify-dev:latest
notation verify ghcr.io/ratify-project/ratify-chart-dev/ratify:0-dev
```

Sample output of `verify`:
Sample output of `verify` for ratify dev image:

```shell
Warning: Always verify the artifact using digest(@sha256:...) rather than a tag(:latest) because resolved digest may not point to the same signed artifact, as tags are mutable.
Expand All @@ -60,21 +63,21 @@ A keyless signature is published per image. The signature is uploaded to the Rek

```shell
cosign verify \
--certificate-identity "https://github.com/ratify-project/ratify/.github/workflows/publish-dev-assets.yml@refs/heads/dev" \
--certificate-identity-regexp "https://github.com/ratify-project/ratify/.github/workflows/publish-package.yml@*" \
--certificate-oidc-issuer https://token.actions.githubusercontent.com \
--certificate-github-workflow-repository ratify-project/ratify \
ghcr.io/ratify-project/ratify-dev:latest
ghcr.io/ratify-project/ratify:v1.4.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get answered above.
REF: #129 (comment)

```

```shell
cosign verify \
--certificate-identity "https://github.com/ratify-project/ratify/.github/workflows/publish-dev-assets.yml@refs/heads/dev" \
--certificate-oidc-issuer https://token.actions.githubusercontent.com \
--certificate-github-workflow-repository ratify-project/ratify \
ghcr.io/ratify-project/ratify-chart-dev/ratify:0-dev
ghcr.io/ratify-project/ratify-dev:latest
```

Sample output:
Sample output of verifcation of ratify dev image:

```shell
Verification for ghcr.io/ratify-project/ratify-dev:latest --
Expand Down