-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add release image signing guidance #129
Open
akashsinghal
wants to merge
3
commits into
ratify-project:main
Choose a base branch
from
akashsinghal:akashsinghal/addReleaseSigning
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ Refer to vulerability management and release documentation [here](https://github | |
|
||
## Signature Validation | ||
|
||
Ratify signs all dev images and dev helm OCI artifacts with Notary Project and Sigstore Cosign signatures. Ratify will support signing release images in the near future. | ||
Ratify signs all release images, dev images, and dev helm OCI artifacts with Notary Project and Sigstore Cosign signatures. | ||
|
||
### Verifying Notary Project Signature | ||
|
||
|
@@ -24,6 +24,9 @@ cat <<EOF > ./trustpolicy.json | |
{ | ||
"name": "ratify-images", | ||
"registryScopes": [ | ||
"ghcr.io/ratify-project/ratify", | ||
"ghcr.io/ratify-project/ratify-base", | ||
"ghcr.io/ratify-project/ratify-crds", | ||
"ghcr.io/ratify-project/ratify-dev", | ||
"ghcr.io/ratify-project/ratify-base-dev", | ||
"ghcr.io/ratify-project/ratify-crds-dev", | ||
|
@@ -41,11 +44,11 @@ cat <<EOF > ./trustpolicy.json | |
} | ||
EOF | ||
notation policy import ./trustpolicy.json | ||
notation verify ghcr.io/ratify-project/ratify:v1.4.0 | ||
notation verify ghcr.io/ratify-project/ratify-dev:latest | ||
notation verify ghcr.io/ratify-project/ratify-chart-dev/ratify:0-dev | ||
``` | ||
|
||
Sample output of `verify`: | ||
Sample output of `verify` for ratify dev image: | ||
|
||
```shell | ||
Warning: Always verify the artifact using digest(@sha256:...) rather than a tag(:latest) because resolved digest may not point to the same signed artifact, as tags are mutable. | ||
|
@@ -60,21 +63,21 @@ A keyless signature is published per image. The signature is uploaded to the Rek | |
|
||
```shell | ||
cosign verify \ | ||
--certificate-identity "https://github.com/ratify-project/ratify/.github/workflows/publish-dev-assets.yml@refs/heads/dev" \ | ||
--certificate-identity-regexp "https://github.com/ratify-project/ratify/.github/workflows/publish-package.yml@*" \ | ||
--certificate-oidc-issuer https://token.actions.githubusercontent.com \ | ||
--certificate-github-workflow-repository ratify-project/ratify \ | ||
ghcr.io/ratify-project/ratify-dev:latest | ||
ghcr.io/ratify-project/ratify:v1.4.0 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Get answered above. |
||
``` | ||
|
||
```shell | ||
cosign verify \ | ||
--certificate-identity "https://github.com/ratify-project/ratify/.github/workflows/publish-dev-assets.yml@refs/heads/dev" \ | ||
--certificate-oidc-issuer https://token.actions.githubusercontent.com \ | ||
--certificate-github-workflow-repository ratify-project/ratify \ | ||
ghcr.io/ratify-project/ratify-chart-dev/ratify:0-dev | ||
ghcr.io/ratify-project/ratify-dev:latest | ||
``` | ||
|
||
Sample output: | ||
Sample output of verifcation of ratify dev image: | ||
|
||
```shell | ||
Verification for ghcr.io/ratify-project/ratify-dev:latest -- | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious about that, since
v1.4.0
is not released shall we go with the latest versionv1.3.1
instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking that updates to the docs here are for the
next
version on the website, which corresponds to unreleased changes. The current v1.3.1 release is not signed so we don't want to give that as an example. When v1.4.0 is released, the published release images will be signed and match the docs.