docs: add release image signing guidance #129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akashsinghal
requested review from
binbin-li,
luisdlp,
susanshi and
toddysm
as code owners
✅ Deploy Preview for ratify-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
junczhu
reviewed
Nov 25, 2024
| @@ -41,11 +44,11 @@ cat <<EOF > ./trustpolicy.json | |||
| } | |||
| EOF | |||
| notation policy import ./trustpolicy.json | |||
| notation verify ghcr.io/ratify-project/ratify:v1.4.0 | |||
There was a problem hiding this comment.
Just curious about that, since v1.4.0 is not released shall we go with the latest version v1.3.1 instead?
There was a problem hiding this comment.
I was thinking that updates to the docs here are for the next version on the website, which corresponds to unreleased changes. The current v1.3.1 release is not signed so we don't want to give that as an example. When v1.4.0 is released, the published release images will be signed and match the docs.
junczhu
reviewed
Nov 25, 2024
| @@ -63,18 +66,18 @@ cosign verify \ | |||
| --certificate-identity "https://github.com/ratify-project/ratify/.github/workflows/publish-dev-assets.yml@refs/heads/dev" \ | |||
| --certificate-oidc-issuer https://token.actions.githubusercontent.com \ | |||
| --certificate-github-workflow-repository ratify-project/ratify \ | |||
| ghcr.io/ratify-project/ratify-dev:latest | |||
| ghcr.io/ratify-project/ratify:v1.4.0 | |||
There was a problem hiding this comment.
Get answered above.
REF: #129 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates security doc to include release image verification guidance