Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Github action in CI to check for a working bazel build #1955

Closed
cramertj opened this issue Sep 25, 2024 · 4 comments
Closed

Add a Github action in CI to check for a working bazel build #1955

cramertj opened this issue Sep 25, 2024 · 4 comments
Milestone

Comments

@cramertj
Copy link
Contributor

Adding a minimal check that does something like:

Would help to track when the Bazel build is broken and needs fixing, as well as helping after-the-fact to figure out what ranges have a known-working Bazel build.

@kilograham kilograham added this to the 2.0.1 milestone Sep 28, 2024
@armandomontanez
Copy link
Contributor

I put together a presubmit in #1973 that covers the following:

  • Pico SDK Bazel build covering RP2040, RP2350, and a few extra configuration flavors (clang, Pico W) for macOS, Linux, and Windows.
  • Host build of the few compatible tests macOS, Linux, and Windows.
  • Pico SDK + Picotool build at HEAD of develop branch for macOS, Linux, and Windows.
  • Pico SDK + Picotool build at current minimum BCR version of Picotool (i.e. oldest backwards-compatible release) for macOS, Linux, and Windows.
  • Various other checks (check to ensure all files are enumerated in the Bazel build, ensure configuration options available in CMake are available in Bazel).

Currently, the macOS and Linux builds are passing. Windows is hitting some issues when building Picotool (unsurprisingly). The "other" check is failing right now since new Pico W-related configuration options were added that I haven't hooked up yet.

A few checks I'd also like to add eventually:

  • Verify submodule pins match pins in MODULE.bazel.
  • Verify project version strings match those in CMake.

@kilograham kilograham modified the milestones: 2.1.0, 2.2.0 Nov 18, 2024
@kilograham
Copy link
Contributor

moving to 2.2.0 as this is now partially done in 2.1.0

@lurch
Copy link
Contributor

lurch commented Nov 19, 2024

@armandomontanez I think these

A few checks I'd also like to add eventually:

  • Verify submodule pins match pins in MODULE.bazel.
  • Verify project version strings match those in CMake.

were both done in #2039 , right?

@armandomontanez
Copy link
Contributor

armandomontanez commented Nov 19, 2024

Yep, we can close this one. We've got a pretty nice set of automated checks now.

@lurch lurch closed this as completed Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants