Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only load the Foundation partials we need #36

Open
sodevious opened this issue Mar 27, 2018 · 3 comments
Open

Only load the Foundation partials we need #36

sodevious opened this issue Mar 27, 2018 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@sodevious
Copy link
Collaborator

My apologies if this is something already on your radar (probably is).

Towards the end of the project, we should make sure to create a manifest file that will only include the Foundation bits we are using and need to include, to avoid deploying unused CSS.

https://foundation.zurb.com/sites/docs/sass.html#adjusting-css-output

@mtrythall
Copy link
Collaborator

Moving comments from Slack. This is a great suggestion and I'm glad you noted it.

Typically during build, we include everything and then we slim it all down when we're done. We're using very little of Foundation ATM, but in the coming weeks, we'll need to clean up our list for sure. I just took a shortcut and did the one-liner to get us up and running.

Feel free to champion this and get us a clear set of config and import files. We'll comment out what we don't need at the end.

@mtrythall mtrythall added the enhancement New feature or request label Mar 28, 2018
@mtrythall mtrythall self-assigned this Apr 6, 2018
sodevious added a commit that referenced this issue Apr 6, 2018
@sodevious
Copy link
Collaborator Author

sodevious commented Apr 16, 2018

Dropping a reminder when we implement this that we should do the same with the Foundation JS.

@sodevious sodevious mentioned this issue Apr 30, 2018
7 tasks
@mtrythall
Copy link
Collaborator

@sodevious I think we're at a point where you can run with this one now.

sodevious added a commit that referenced this issue May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants