New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileNameInformation Link No Longer Contains Structure Info #221

Open

gwillcox-r7 opened this issue May 9, 2022 · 1 comment

Contributor

gwillcox-r7 commented May 9, 2022

https://github.com/rapid7/ruby_smb/blob/master/lib/ruby_smb/fscc/file_information/file_name_information.rb#L5 contains a link to https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-fscc/cb30e415-54c5-4483-a346-822ea90e1e89 however it seems like MS removed the definition of the fields here so the only way to review this information now is to download the specs file from https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-fscc/efbfe127-73ad-4140-9967-ec6500e66d5e.

It may be worthwhile considering if we want to update the link accordingly.

Contributor Author

gwillcox-r7 commented May 9, 2022

Actually this should link to https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-fscc/20406fb1-605f-4629-ba9a-c67ee25f23d2 I stand corrected, which defines this structure. It appears the link was to the wrong definition and someone searched for FILENAMEINFORMATION vs FILE_NAME_INFORMATION and therefore got the wrong definition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment