Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored model selection and added docstrings the functions #95

Merged
merged 7 commits into from
Nov 22, 2024
Merged

Refactored model selection and added docstrings the functions #95

merged 7 commits into from
Nov 22, 2024

Conversation

anushka255
Copy link
Collaborator

No description provided.

@anushka255 anushka255 changed the title refactored model selection and added docstrings to some of the functions Refactored model selection and added docstrings to some of the functions Nov 21, 2024
@anushka255 anushka255 marked this pull request as ready for review November 21, 2024 21:56
@anushka255 anushka255 marked this pull request as draft November 22, 2024 15:08
@anushka255 anushka255 changed the title Refactored model selection and added docstrings to some of the functions Refactored model selection and added docstrings the functions Nov 22, 2024
@anushka255 anushka255 marked this pull request as ready for review November 22, 2024 16:21
vineetbansal
vineetbansal approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@vineetbansal vineetbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! There are probably a couple of places where we can vectorize the code but that's a minor issue that I'll open up separately.

@vineetbansal vineetbansal merged commit 31c8530 into main Nov 22, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vineetbansal vineetbansal vineetbansal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anushka255 @vineetbansal