EC_AffinePoint API improvements #4446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reneme
approved these changes
Nov 27, 2024
This adds point negation and point addition. Point addition is not particularly efficient since it converts the result immediately to an affine coordinate, as we do not currently expose projective points at all. That said it is more than sufficient for simple protocols that just need to add a few points together. This also corrects the return result of EC_AffinePoint::mul_px_qy, which would previously crash if the resulting point was the identity element. Instead it should return nullopt. Discussion in #4027
randombit
force-pushed
the
jack/add-pt-addition
branch
from
e6e4c7a to
28bf67c
Compare
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds point negation and point addition.
Point addition is not particularly efficient since it converts the result immediately to an affine coordinate, as we do not currently expose projective points at all. That said it is more than sufficient for simple protocols that just need to add a few points together.
This also corrects the return result of EC_AffinePoint::mul_px_qy, which would previously crash if the resulting point was the identity element. Instead it should return nullopt.
Discussion in #4027