Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One-Step Key Derivation Method with KMAC #4121

Merged
merged 3 commits into from
Jun 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions doc/api_ref/kdf.rst
Original file line number Diff line number Diff line change
Expand Up @@ -158,19 +158,20 @@ e.g. ``X9.42-PRF(KeyWrap.TripleDES)``, ``X9.42-PRF(1.2.840.113549.1.9.16.3.7)``
SP800-56A
~~~~~~~~~~

KDF from NIST SP 800-56A.
KDF from NIST SP 800-56Ar2 or One-Step KDF of SP 800-56Cr2.

Available if ``BOTAN_HAS_SP800_56A`` is defined.

Algorithm specification names:

- ``SP800-56A(<HashFunction>)``, e.g. ``SP800-56A(SHA-256)``
- ``SP800-56A(HMAC(<HashFunction>))``, e.g. ``SP800-56A(HMAC(SHA-256))``
- ``SP800-56A(KMAC-128)`` or ``SP800-56A(KMAC-256)``

SP800-56C
~~~~~~~~~~

KDF from NIST SP 800-56C.
Two-Step KDF from NIST SP 800-56Cr2.

Available if ``BOTAN_HAS_SP800_56C`` is defined.

Expand Down
18 changes: 12 additions & 6 deletions src/lib/kdf/kdf.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,11 @@
#endif

#if defined(BOTAN_HAS_SP800_56A)
#include <botan/internal/sp800_56a.h>
#include <botan/internal/sp800_56c_one_step.h>
#endif

#if defined(BOTAN_HAS_SP800_56C)
#include <botan/internal/sp800_56c.h>
#include <botan/internal/sp800_56c_two_step.h>
#endif

namespace Botan {
Expand Down Expand Up @@ -160,10 +160,16 @@ std::unique_ptr<KDF> KDF::create(std::string_view algo_spec, std::string_view pr
#if defined(BOTAN_HAS_SP800_56A)
if(req.algo_name() == "SP800-56A" && req.arg_count() == 1) {
if(auto hash = HashFunction::create(req.arg(0))) {
return std::make_unique<SP800_56A_Hash>(std::move(hash));
return std::make_unique<SP800_56C_One_Step_Hash>(std::move(hash));
}
if(req.arg(0) == "KMAC-128") {
return std::make_unique<SP800_56C_One_Step_KMAC128>();
}
if(req.arg(0) == "KMAC-256") {
return std::make_unique<SP800_56C_One_Step_KMAC256>();
}
if(auto mac = MessageAuthenticationCode::create(req.arg(0))) {
return std::make_unique<SP800_56A_HMAC>(std::move(mac));
return std::make_unique<SP800_56C_One_Step_HMAC>(std::move(mac));
}
}
#endif
Expand All @@ -173,11 +179,11 @@ std::unique_ptr<KDF> KDF::create(std::string_view algo_spec, std::string_view pr
std::unique_ptr<KDF> exp(kdf_create_mac_or_hash<SP800_108_Feedback>(req.arg(0)));
if(exp) {
if(auto mac = MessageAuthenticationCode::create(req.arg(0))) {
return std::make_unique<SP800_56C>(std::move(mac), std::move(exp));
return std::make_unique<SP800_56C_Two_Step>(std::move(mac), std::move(exp));
}

if(auto mac = MessageAuthenticationCode::create(fmt("HMAC({})", req.arg(0)))) {
return std::make_unique<SP800_56C>(std::move(mac), std::move(exp));
return std::make_unique<SP800_56C_Two_Step>(std::move(mac), std::move(exp));
}
}
}
Expand Down
1 change: 1 addition & 0 deletions src/lib/kdf/sp800_56a/info.txt
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,5 @@ name -> "NIST SP800-56A"

<requires>
hmac
kmac
</requires>
112 changes: 0 additions & 112 deletions src/lib/kdf/sp800_56a/sp800_56a.cpp

This file was deleted.

109 changes: 0 additions & 109 deletions src/lib/kdf/sp800_56a/sp800_56a.h

This file was deleted.

Loading
Loading