Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add faster reduction for secp256k1 pcurves #4113

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Add faster reduction for secp256k1 pcurves #4113

merged 3 commits into from
Jul 12, 2024

Conversation

randombit
Copy link
Owner

@randombit randombit commented Jun 11, 2024 •
edited
Loading

This takes advantage of the modulus being near a power of 2.

Rough idea of improvements. Seems to vary a lot between compilers and CPUs:

  • Sandybridge/GCC: ECDH and ECDSA all about 9% faster
  • Skylake/GCC: ECDH 19% faster, ECDSA sign 13% faster, ECDSA verify 17% faster

#4027

@randombit randombit requested review from reneme and FAlbertDev June 11, 2024 12:03
@randombit randombit force-pushed the jack/faster-k1-redc branch from b89ed62 to 4cd489f Compare June 11, 2024 12:09
@coveralls
Copy link

Coverage Status

coverage: 91.771% (+0.005%) from 91.766%
when pulling 4cd489f on jack/faster-k1-redc
into 856174e on master.

@coveralls
Copy link

Coverage Status

coverage: 91.77% (+0.004%) from 91.766%
when pulling 8839e0a on jack/faster-k1-redc
into 856174e on master.

@randombit randombit added this to the Botan 3.5.0 milestone Jun 12, 2024
@coveralls
Copy link

Coverage Status

coverage: 91.78% (+0.01%) from 91.766%
when pulling 5815410 on jack/faster-k1-redc
into 856174e on master.

@randombit randombit force-pushed the jack/faster-k1-redc branch from 5815410 to c33c00f Compare June 14, 2024 21:29
@coveralls
Copy link

Coverage Status

coverage: 91.776% (-0.006%) from 91.782%
when pulling c33c00f on jack/faster-k1-redc
into 4c3e9dc on master.

@randombit randombit force-pushed the jack/faster-k1-redc branch from c33c00f to efdbdc8 Compare June 14, 2024 22:39
@coveralls
Copy link

Coverage Status

coverage: 91.779% (-0.003%) from 91.782%
when pulling efdbdc8 on jack/faster-k1-redc
into 4c3e9dc on master.

@randombit randombit mentioned this pull request Jun 15, 2024
Open
20 tasks
@randombit randombit modified the milestones: Botan 3.5.0, Botan 3.6.0 Jun 22, 2024
@randombit randombit force-pushed the jack/faster-k1-redc branch from efdbdc8 to ed73a18 Compare July 9, 2024 00:55
randombit added 3 commits July 10, 2024 06:52
@randombit
Small cleanups in P-521 pcurve code
b32443a
@randombit
Skip pcurves_points under the short valgrind run
3c44844
@randombit
Add specialized reduction for secp256k1
ac87424 
This takes advantage of the modulus being near a power of 2.

Performance improvement varies by CPU, compiler, and specific
algorithm in use, but generally ranges between 10% to 20%.
@randombit randombit force-pushed the jack/faster-k1-redc branch from ed73a18 to ac87424 Compare July 10, 2024 10:52
@coveralls
Copy link

Coverage Status

coverage: 91.727% (+0.001%) from 91.726%
when pulling ac87424 on jack/faster-k1-redc
into 7fad1d2 on master.

@randombit randombit merged commit 1af5545 into master Jul 12, 2024
39 checks passed
@randombit randombit deleted the jack/faster-k1-redc branch July 12, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reneme reneme Awaiting requested review from reneme

@FAlbertDev FAlbertDev Awaiting requested review from FAlbertDev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Botan 3.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@randombit @coveralls