From 2afeb625324749ffd2e24b0ad87a4502b3b2d7d7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lars=20Silv=C3=A9n?= <lars@pkimodules.com>
Date: Mon, 1 Jan 2024 17:54:31 +0100
Subject: [PATCH] Changing from local to public for some parts of the API.

This is done to make it possible to use none Botan private keys when signing certificates.
---
 src/lib/asn1/info.txt                 | 2 +-
 src/lib/asn1/pss_params.cpp           | 2 +-
 src/lib/asn1/pss_params.h             | 2 +-
 src/lib/prov/pkcs11/info.txt          | 5 +----
 src/lib/prov/pkcs11/p11_ecdh.cpp      | 2 +-
 src/lib/prov/pkcs11/p11_ecdsa.cpp     | 2 +-
 src/lib/prov/pkcs11/p11_mechanism.cpp | 2 +-
 src/lib/prov/pkcs11/p11_mechanism.h   | 2 +-
 src/lib/prov/pkcs11/p11_rsa.cpp       | 2 +-
 src/lib/pubkey/pubkey.cpp             | 2 +-
 src/lib/pubkey/rsa/rsa.cpp            | 2 +-
 src/lib/tls/tls_signature_scheme.cpp  | 2 +-
 12 files changed, 12 insertions(+), 15 deletions(-)

diff --git a/src/lib/asn1/info.txt b/src/lib/asn1/info.txt
index dc80cdbd462..ec2591cec49 100644
--- a/src/lib/asn1/info.txt
+++ b/src/lib/asn1/info.txt
@@ -17,9 +17,9 @@ asn1_obj.h
 der_enc.h
 oids.h
 ber_dec.h
+pss_params.h
 </header:public>
 
 <header:internal>
 oid_map.h
-pss_params.h
 </header:internal>
diff --git a/src/lib/asn1/pss_params.cpp b/src/lib/asn1/pss_params.cpp
index a6e0ab3e4b2..014906691a9 100644
--- a/src/lib/asn1/pss_params.cpp
+++ b/src/lib/asn1/pss_params.cpp
@@ -5,7 +5,7 @@
 * Botan is released under the Simplified BSD License (see license.txt)
 */
 
-#include <botan/internal/pss_params.h>
+#include <botan/pss_params.h>
 
 #include <botan/ber_dec.h>
 #include <botan/der_enc.h>
diff --git a/src/lib/asn1/pss_params.h b/src/lib/asn1/pss_params.h
index fec4e9fc0a6..b2349d3fd82 100644
--- a/src/lib/asn1/pss_params.h
+++ b/src/lib/asn1/pss_params.h
@@ -13,7 +13,7 @@
 
 namespace Botan {
 
-class PSS_Params final : public ASN1_Object {
+class BOTAN_PUBLIC_API(3, 6) PSS_Params final : public ASN1_Object {
    public:
       static PSS_Params from_emsa_name(std::string_view emsa_name);
 
diff --git a/src/lib/prov/pkcs11/info.txt b/src/lib/prov/pkcs11/info.txt
index 050f484e451..6141f729aac 100644
--- a/src/lib/prov/pkcs11/info.txt
+++ b/src/lib/prov/pkcs11/info.txt
@@ -14,10 +14,6 @@ pubkey
 pk_pad
 </requires>
 
-<header:internal>
-p11_mechanism.h
-</header:internal>
-
 <header:external>
 pkcs11.h
 pkcs11f.h
@@ -34,4 +30,5 @@ p11_randomgenerator.h
 p11_rsa.h
 p11_types.h
 p11_x509.h
+p11_mechanism.h
 </header:public>
diff --git a/src/lib/prov/pkcs11/p11_ecdh.cpp b/src/lib/prov/pkcs11/p11_ecdh.cpp
index d4ad64b76d5..ac6b09a4b75 100644
--- a/src/lib/prov/pkcs11/p11_ecdh.cpp
+++ b/src/lib/prov/pkcs11/p11_ecdh.cpp
@@ -13,7 +13,7 @@
    #include <botan/der_enc.h>
    #include <botan/pk_ops.h>
    #include <botan/rng.h>
-   #include <botan/internal/p11_mechanism.h>
+   #include <botan/p11_mechanism.h>
 
 namespace Botan::PKCS11 {
 
diff --git a/src/lib/prov/pkcs11/p11_ecdsa.cpp b/src/lib/prov/pkcs11/p11_ecdsa.cpp
index 24533d7b515..90b8092e738 100644
--- a/src/lib/prov/pkcs11/p11_ecdsa.cpp
+++ b/src/lib/prov/pkcs11/p11_ecdsa.cpp
@@ -13,7 +13,7 @@
    #include <botan/pk_ops.h>
    #include <botan/rng.h>
    #include <botan/internal/keypair.h>
-   #include <botan/internal/p11_mechanism.h>
+   #include <botan/p11_mechanism.h>
 
 namespace Botan::PKCS11 {
 
diff --git a/src/lib/prov/pkcs11/p11_mechanism.cpp b/src/lib/prov/pkcs11/p11_mechanism.cpp
index 1db137c284f..209e3eb984b 100644
--- a/src/lib/prov/pkcs11/p11_mechanism.cpp
+++ b/src/lib/prov/pkcs11/p11_mechanism.cpp
@@ -6,7 +6,7 @@
 * Botan is released under the Simplified BSD License (see license.txt)
 */
 
-#include <botan/internal/p11_mechanism.h>
+#include <botan/p11_mechanism.h>
 
 #include <botan/internal/fmt.h>
 #include <botan/internal/parsing.h>
diff --git a/src/lib/prov/pkcs11/p11_mechanism.h b/src/lib/prov/pkcs11/p11_mechanism.h
index 96ea0dc1541..9aabb403cab 100644
--- a/src/lib/prov/pkcs11/p11_mechanism.h
+++ b/src/lib/prov/pkcs11/p11_mechanism.h
@@ -23,7 +23,7 @@ namespace Botan::PKCS11 {
 * for RSA (encryption/decryption, signature/verification)
 * and EC (ECDSA signature/verification, ECDH key derivation).
 */
-class MechanismWrapper final {
+class BOTAN_PUBLIC_API(3, 6) MechanismWrapper final {
    public:
       /// @param mechanism_type the CK_MECHANISM_TYPE for the `mechanism` field of the CK_MECHANISM struct
       explicit MechanismWrapper(MechanismType mechanism_type);
diff --git a/src/lib/prov/pkcs11/p11_rsa.cpp b/src/lib/prov/pkcs11/p11_rsa.cpp
index 6ed7311c378..af92ea99ae9 100644
--- a/src/lib/prov/pkcs11/p11_rsa.cpp
+++ b/src/lib/prov/pkcs11/p11_rsa.cpp
@@ -15,7 +15,7 @@
    #include <botan/pubkey.h>
    #include <botan/rng.h>
    #include <botan/internal/blinding.h>
-   #include <botan/internal/p11_mechanism.h>
+   #include <botan/p11_mechanism.h>
    #include <botan/internal/pk_ops_impl.h>
 
 namespace Botan::PKCS11 {
diff --git a/src/lib/pubkey/pubkey.cpp b/src/lib/pubkey/pubkey.cpp
index 15fb3632157..c0287c38d33 100644
--- a/src/lib/pubkey/pubkey.cpp
+++ b/src/lib/pubkey/pubkey.cpp
@@ -12,10 +12,10 @@
 #include <botan/mem_ops.h>
 #include <botan/pk_ops.h>
 #include <botan/rng.h>
+#include <botan/pss_params.h>
 #include <botan/internal/ct_utils.h>
 #include <botan/internal/fmt.h>
 #include <botan/internal/parsing.h>
-#include <botan/internal/pss_params.h>
 #include <botan/internal/stl_util.h>
 
 namespace Botan {
diff --git a/src/lib/pubkey/rsa/rsa.cpp b/src/lib/pubkey/rsa/rsa.cpp
index 8ae7e444d66..7bed614494c 100644
--- a/src/lib/pubkey/rsa/rsa.cpp
+++ b/src/lib/pubkey/rsa/rsa.cpp
@@ -10,6 +10,7 @@
 #include <botan/ber_dec.h>
 #include <botan/der_enc.h>
 #include <botan/reducer.h>
+#include <botan/pss_params.h>
 #include <botan/internal/blinding.h>
 #include <botan/internal/divide.h>
 #include <botan/internal/emsa.h>
@@ -19,7 +20,6 @@
 #include <botan/internal/monty_exp.h>
 #include <botan/internal/parsing.h>
 #include <botan/internal/pk_ops_impl.h>
-#include <botan/internal/pss_params.h>
 #include <botan/internal/workfactor.h>
 
 #if defined(BOTAN_HAS_THREAD_UTILS)
diff --git a/src/lib/tls/tls_signature_scheme.cpp b/src/lib/tls/tls_signature_scheme.cpp
index ce285019388..2b33df82f65 100644
--- a/src/lib/tls/tls_signature_scheme.cpp
+++ b/src/lib/tls/tls_signature_scheme.cpp
@@ -13,7 +13,7 @@
 #include <botan/hex.h>
 #include <botan/tls_exceptn.h>
 #include <botan/tls_version.h>
-#include <botan/internal/pss_params.h>
+#include <botan/pss_params.h>
 #include <botan/internal/stl_util.h>
 
 namespace Botan::TLS {