Skip to content
This repository has been archived by the owner on Apr 15, 2022. It is now read-only.

Use an associated constant for type name in Describe #16

Open
randomPoison opened this issue May 15, 2020 · 0 comments
Open

Use an associated constant for type name in Describe #16

randomPoison opened this issue May 15, 2020 · 0 comments
Labels
blocked The ticket is blocked on another ticket or an external dependency enhancement New feature or request

Comments

@randomPoison
Copy link
Owner

Blocked by rust-lang/rust#47032.

As of #15 the Describe trait has an associated function type_name to get the TypeName for a describable type. We'd prefer to use an associated constant, since a type's name should be fully known at compile time. However, to do that we need to change the type_params field of TypeName to be a Cow<'static, [TypeName]>, but there's currently a rustc bug rust-lang/rust#47032 that causes that code to not compile. Once rust-lang/rust#47032 has been fixed, we should switch to using an associated constant, and either deprecate or fully remove the type_name function.

@randomPoison randomPoison added enhancement New feature or request blocked The ticket is blocked on another ticket or an external dependency labels May 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked The ticket is blocked on another ticket or an external dependency enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant