Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust logic for adding manifests after first server and last server #198

Open
aleiner opened this issue Mar 27, 2024 · 2 comments
Open

Comments

@aleiner
Copy link
Contributor

aleiner commented Mar 27, 2024

Currently, add-manifest-addons runs after the first node and add-cluster-manifests-addons runs after the last server. Possibly rethink logic.

@mddamato
Copy link
Contributor

We need to document and reorganize the manifests logic so that it's more intuitive. Right now the add-manifest-addons adds the manifest files after the first server is healthy. This causes some applications to not function properly until the other servers are healthy, so we attempted a workaround with a new role. This approach also presents issues for other types of applications so we need both solutions. in 198 we plan to find a cleaner way to upload manifests files both before and after the servers are healthy and do it in a way that will not require a third role. considered a breaking change so we should cut a new release tag after this.

@aleiner
Copy link
Contributor Author

aleiner commented Jun 21, 2024

addressed via #246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants