Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo in label? #123

Closed
rgcosma opened this issue Nov 26, 2024 · 2 comments
Closed

typo in label? #123

rgcosma opened this issue Nov 26, 2024 · 2 comments
Assignees
@mallardduck
Labels
team/observability&backup
Milestone
v2.11.0

Comments

@rgcosma
Copy link

rgcosma commented Nov 26, 2024

https://github.com/search?q=repo%3Arancher%2Fprometheus-federator%20prometheus1&type=code looks like a typo thatțs been in there since 0.4.0
@mallardduck mallardduck mentioned this issue Dec 11, 2024
Merged
@mallardduck mallardduck self-assigned this Dec 11, 2024
@mallardduck
Copy link
Member

mallardduck commented Dec 13, 2024 •
edited
Loading

The Charts side (that ships the fix): rancher/charts#4872
Chart RC to test: PromFed 105.1.0-rc.1+up0.4.5-rc.1
Note: expected container image is: v0.4.4-rc.2

@mallardduck mallardduck added this to the v2.11.0 milestone Dec 17, 2024
@pankajsqe
Copy link

typo error has been fixed and verified on PR with below config.

Details
Rancher : V2.11-head
PromFed : 105.1.0-rc.1+up0.4.5-rc.1
Cluster : v1.31.1+rke2r1

@mallardduck mallardduck mentioned this issue Dec 23, 2024
Open
@mallardduck mallardduck mentioned this issue Jan 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mallardduck mallardduck

Labels
team/observability&backup
Projects
None yet
Milestone
v2.11.0
Development

No branches or pull requests
3 participants
@mallardduck @rgcosma @pankajsqe