Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update swaps sdk & rip out WRAPPED_ASSET dependency #1783

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

welps
Copy link
Member

@welps welps commented Dec 11, 2024

This removes the dependency on hardcoded addresses for wrapped native assets

Copy link

socket-security bot commented Dec 11, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@rainbow-me/[email protected] environment, eval, network +2 2.05 MB brunobar79

🚮 Removed packages: npm/@rainbow-me/[email protected]

View full report↗︎

@DanielSinclair
Copy link
Collaborator

@BrodyHughes Can you do a QA pass on this? Thank you!

Copy link
Member

@BrodyHughes BrodyHughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked:

  • Swaps: ✅
    • Mainnet swap: ✅
    • OP swap: ✅
    • Arb swap: ✅
    • Degen swap: ✅
    • Ape swap: ✅
  • Wraps: ✅
    • Mainnet wrap / unwrap: ✅
    • OP wrap / unwrap: ✅
    • Arb wrap / unwrap: ✅
    • Degen wrap / unwrap: ✅
    • Ape wrap / unwrap: ✅
      • not a regression, but flagged an issue with balance of wape not showing up and with wraps being labelled as ‘deposit’ instead of ‘wraps

@DanielSinclair DanielSinclair force-pushed the @welps/update-swaps-sdk branch from 04458a0 to f59a4cf Compare December 16, 2024 18:07
@welps
Copy link
Member Author

welps commented Dec 17, 2024

@BrodyHughes Can you confirm if the e2e swap failure is from my branch or if it 's widespread? if the latter, can we just merge this?

@BrodyHughes
Copy link
Member

BrodyHughes commented Dec 17, 2024

@BrodyHughes Can you confirm if the e2e swap failure is from my branch or if it 's widespread? if the latter, can we just merge this?

I just reran the test and it passed, so it was just flakiness. Still need another review though before merging.

@DanielSinclair DanielSinclair merged commit 8c0bd8d into master Dec 17, 2024
14 checks passed
@DanielSinclair DanielSinclair deleted the @welps/update-swaps-sdk branch December 17, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants