Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question / Compatibility Issue #60

Open
mvastola opened this issue Nov 21, 2020 · 0 comments
Open

Question / Compatibility Issue #60

mvastola opened this issue Nov 21, 2020 · 0 comments

Comments

@mvastola
Copy link

Hi, just two things:

Clarification

What is the relationship between this repo and api.rubyonrails.org? I came across this in looking for the source for the latter (which I still haven't found), and this is the closest thing to it that I've found, except it has a different theme.

Is this meant to be a staging ground for a draft PR, or is this an actual project used by rubyonrails.org and they haven't published their fork, etc?

Compatibility Issue

Also, in trying to run this project locally, I ran into a small issue that required tweaking the Rakefile. I'd submit a PR, but I don't really know the status of this repo or the environments it's intended to be used in.

Basically though, I'm on Ubuntu and the sed utility doesn't work with if an empty argument is given after the -i switch (the empty string it interpreted as a filename and results in the error sed: can't read : No such file or directory).

Also, my ruby install uses a 2.x version of bundler, so the bundle install command errors out in the rails dir and, tells me to either install the 1.x version of bundler used to generate the Gemfile or run bundle update --bundler. I personally just ran the latter, but the other way to address this would be to add require the 1.x version as a dependency (or otherwise install it in the Rakefile).

My ultimate changes:

diff --git a/Rakefile b/Rakefile
index dc1d6aba..c0576cef 100644
--- a/Rakefile
+++ b/Rakefile
@@ -1,7 +1,8 @@
task :build do
cd 'rails' do
Bundler.with_unbundled_env do
-      sh %(sed -i '' -e 's/sdoc.*$/sdoc", github: "toshimaru\\/sdoc", branch: "railsdoc"/g' ./Gemfile)
+      sh %(sed -i -e 's/sdoc.*$/sdoc", github: "toshimaru\\/sdoc", branch: "railsdoc"/g' ./Gemfile)
+      sh 'bundle update --bundler'
sh 'bundle install && bundle update sdoc'
rm_rf 'doc'
sh 'bundle exec rake rdoc'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant