Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client should raise error on failed execution #451

Closed
scbabacus-midnight opened this issue Dec 23, 2019 · 3 comments
Closed

Client should raise error on failed execution #451

scbabacus-midnight opened this issue Dec 23, 2019 · 3 comments

Comments

@scbabacus-midnight
Copy link

Environment

Debian (Docker)
Image ruby:2

I am wondering if execute should raise TinyTds::Error on failed execution?
See more info here:
rails-sqlserver/activerecord-sqlserver-adapter#717

To summarize the consumer got false as a return value which IMO totally unexpected.
I wonder did you forgot to raise an error in ruby instead of returning false from the native C to the consumer?
@scbabacus-midnight
Copy link
Author

cc @metaskills
2a8b8e9

@scbabacus-midnight scbabacus-midnight mentioned this issue Dec 23, 2019
Closed
@aharpervc
Copy link
Contributor

This seems like a plausible bug to me. Is it possible to write a new TinyTDS test case to verify the expected behavior?

@wpolicarpo wpolicarpo mentioned this issue May 15, 2020
Closed
@andyundso
Copy link
Member

This has been fixed with #560 and released with v3.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Raise error if client is unable to execute statement rails-sqlserver/tiny_tds
3 participants
@aharpervc @andyundso @scbabacus-midnight