Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated TDS version information in README? #447

Closed
betelgeuse opened this issue Nov 11, 2019 · 2 comments · Fixed by #572
Closed

Outdated TDS version information in README? #447

betelgeuse opened this issue Nov 11, 2019 · 2 comments · Fixed by #572

Comments

@betelgeuse
Copy link

Under the header "FreeTDS Compatibility & Configuration" README says: "We are currently having issues with passing down a TDS version with the login bit. Till we get that fixed, if you are not using a freetds.conf or a TDSVER environment variable, then make sure to use 7.1."

Later under "TinyTds::Client Usage" it says: ":tds_version - TDS version. Defaults to "7.3"."

Based on blame history besides a typo change the section "FreeTDS Compatibility & Configuration" has not been updated for many years and I assume is out of date.

@aharpervc
Copy link
Contributor

Looks like the default changed here with the switch to FreeTDS 1.0. Can you open a PR to update the readme?

@andyundso
Copy link
Member

I have updated the FreeTDS version information last month with #567. Generally, I think it's good when people use very recent versions regardless of what our README tells.

The part about We are currently having issues with passing down a TDS version with the login bit. was originally added in 11dee35. I would suspect this is no longer accurate, but will have to do a couple of tests before removing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants