Light Turns On/Off when setting fan speed with slider

[flavius-sd]

AFTER TESTING MORE, THIS DOES NOT FIX THE ISSUE

Great work on getting this to work on the new app!

I had an issue when I installed it where the light on the fan would turn on or off if I changed fan speed using the slider. I thought it may have been related to this line of code, so I commented it out and after quick testing looks like it fixed the issue.

In King of Fans Zigbee Fan Controller:
From the Fan Events definition:

//result << sendEvent(name: "lightBrightness", value: speedToDimmerLevel(speed), displayed: true, isStateChange: true)

One thing it may have broken is if you are in the fan setting and turn it off using the power button, the light does not turn off.

[flavius-sd]

Nevermind, tested some more and the issue is still there... seems to only occur when you jump more than two fan speeds at once.

[rafaelborja]

I could not reproduce the issue. Could you give me more details about it?

[rafaelborja]

Hi @flavius-sd

I submitted a fix on branch v.02.

Please let me know if you the issue is fixed.

[flavius-sd]

I might not have updated it correctly (it has been a while) but I updated it and published it, and now when I have the fan speed at “Max” and use the fan slider to adjust the speed, the light turns off. If I start at “High” and adjust the speed the light doesn’t change state. Thank you!!! Joe

…

On Mon, Aug 17, 2020 at 9:22 PM Rafael Borja ***@***.***> wrote: Hi @flavius-sd <https://github.com/flavius-sd> I submitted a fix on branch v.02. Please let me know if you the issue is fixed. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APTWZTANKCTDTZZCFS6SPL3SBH6X7ANCNFSM4NDNFDFQ> .

[rafaelborja]

Sorry @flavius-sd ,

I was not able to reproduce the issue. Please try unistalling and installing the latest version on master.

Best regards!

[flavius-sd]

Okay, will try that... thank you.

…

On Tue, Aug 18, 2020 at 1:14 PM Rafael Borja ***@***.***> wrote: Sorry @flavius-sd <https://github.com/flavius-sd> , I was not able to reproduce the issue. Please try unistalling and installing the latest version on master. Best regards! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APTWZTDH3A3TXNHXIILN4LDSBLOLHANCNFSM4NDNFDFQ> .

[lovejoyr]

Hi, I get the same issue. Sometimes that fan slider works fine but sometimes I experience the issue where the light randomly turns off when I change the fan speed by slider; I think it only happens when switching from Max fan to a different setting (but not every time). Sometimes afterwards it seems as though the whole thing (fan and light control) stops working until I power off and back on the fan circuit. Sometimes when this happens the Light child device shows offline and wont work again until I edit & save the device in the ST website (don't have to change anything, just edit & save). Clean install off the master branch today. Happy to send you logs if they exist/would help.

[lovejoyr]

Also, not sure if it's relevant, but i've seen the "fan speed" label say 5 and 6, and i've seen the dimmer say 125% (in the fan device) when dimmer set to control fan

[lovejoyr]

Believe line 560 (fan controller dimmerLevelToSpeed) should be /25 not /20 - that fixes fan speed label and other general weirdness, but not the light turning off. The light turning off seems like a crash rather than a 'light off' command. Once it happens it doesn't work again until circuit power off and back on

[GitHubGoody]

@rafaelborja I have this same issue. I'm trying to update to v2.2, but there's nothing to pull in under "Obsolete" in the IDE DTH "Update from Repo" list.

[rafaelborja]

@rafaelborja I have this same issue. I'm trying to update to v2.2, but there's nothing to pull in under "Obsolete" in the IDE DTH "Update from Repo" list.

Are you sure you are using the right branch?

[GitHubGoody]

I'm using Master. The changes you just pulled into Master forced an update, but the problem persists (Max>High=Light Turns Off, Med>High=Light Stays On).