Add & setup jest & istanbul #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
rae-ralston
requested changes
Feb 4, 2018
There was a problem hiding this comment.
Hey @Atul9,
Great start. Let's keep to es6 syntax, see my comments.
Some things have come up, so it might take me a couple days to get CI initialized.
submit a new PR with these changes and I'll merge you.
| @@ -1,3 +1,5 @@ | |||
| export function convertToURI(str) { | |||
| function convertToURI(str) { | |||
There was a problem hiding this comment.
change this back to the non-default es6 export syntax.
| @@ -0,0 +1,4 @@ | |||
| var convertToURI = require('../src/helpers.js') | |||
There was a problem hiding this comment.
let's stick to es6 import syntax
import { converToUri } from '../src/helpers'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #19