Added python3 support #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raddevon
requested changes
May 9, 2017
There was a problem hiding this comment.
Thank you for the contribution! Sorry it has taken me a while to review. If you can fix two items, I'll get this merged:
- Make the build status reflect build status for this repo.
- Clean up the requirements. Looks like some packages got in there that are not required for Flask-Permissions (or feel free to correct me if I'm wrong on this)
|
I reverted last commit with README. (I thought that if I will make pull request and then commit changes to README, they won't be included in pull request) |
raddevon
approved these changes
May 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for python3, fixed issue with creating make_user_role_table, updated travis recipe