Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: we don't want the env name in the flavor #541

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Conversation

cardoe
Copy link
Contributor

@cardoe cardoe commented Dec 9, 2024

We don't want to be prefixing the flavor names with an environment name. Just put the environment data in the correct place.

@cardoe cardoe requested a review from a team December 9, 2024 22:28
@cardoe cardoe force-pushed the remove-env-name-flavor branch 2 times, most recently from be2c916 to 78c0c92 Compare December 9, 2024 22:32
We don't want to be prefixing the flavor names with an environment name.
Just put the environment data in the correct place.
@cardoe cardoe force-pushed the remove-env-name-flavor branch from 78c0c92 to c354704 Compare December 9, 2024 22:34
Copy link
Collaborator

@skrobul skrobul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok so codewise the matching should work now, but where is the configuration that decides which flavor types to be used?

I assume we want to just mount the prod or nonprod into /etc/understack_flavors/, but that does not seem to be implemented yet:

Copy link
Collaborator

@skrobul skrobul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/RSS-Engineering/undercloud-deploy/pull/245 adds the missing piece of setting the FLAVORS_DIR for both enroll-server and nova-flavors. With this, I think that PR makes more sense.

@cardoe cardoe added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit 464fcce Dec 12, 2024
26 checks passed
@cardoe cardoe deleted the remove-env-name-flavor branch December 12, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants