feat(maas_api): list agent connections #528
Conversation
This PR adds a new API call that recently landed in MaaS and Intelligence is starting to use. It's likely to become our new preferred way to test if an agent is connected, since the real API has superior performance when testing many agent connections at once.
Current coverage is
|
| for dc in ('dfw1', 'ord1', 'lon3')] | ||
|
|
||
|
|
||
| @attributes([Attribute('id', instance_of=text_type), |
There was a problem hiding this comment.
In the future, we should be moving to attrs, rather than characteristic. There's nothing wrong with Characteristic, and it is still maintained, but attrs has a few subtle advantages and eventually we'd like to be on just one utility library of this type. (You can really think of attrs as characteristic NG, it's a newer library by the same author for the same purpose.)
There was a problem hiding this comment.
I'm actually working on a PR upstream to redo this module in terms of attrs, but wanted to get the feature out first.
There was a problem hiding this comment.
Yep. Not a blocking comment.
|
Whoops. See immediately preceding referenced comment. |
feat(maas_api): list agent connections
|
Filed #531 . |
This PR adds a new API call that recently landed in MaaS and
Intelligence is starting to use. It's likely to become our new preferred
way to test if an agent is connected, since the real API has superior
performance when testing many agent connections at once.