Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert AMQP 1.0 props and app props to AMQP 0.9.1 props and headers (backport #10037) #11729

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Commits on Jul 16, 2024

  1. Convert AMQP 1.0 props and app props to AMQP 0.9.1 props and headers

    - Timestamps are milliseconds in AMQP 1.0, but in AMQP 0.9.1 it is seconds.
      Fixed by multiplying the timestamp by 1 000.
    - Shovel crashed if user_id was set in the message because the encoding
      was as utf8 while it should be a byte array.
    - Negative integers were encoded as integers - therefore leading to
      incorrect positive values.
    - Float values were not supported by the client.
    - Fixed priority header encoding in AMQP 1.0. It was set as uint but it
      should be ubyte.
    - Priority of the message is now in the Headers instead of Application
      Properties. This is potentially a breaking change.
    
    Fixes: #7508
    (cherry picked from commit 8e954ff)
    olikasg authored and kjnilsson committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    f5b1f4e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cad6143 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Shovel: fix some test assertions.

    In line with internal RabbitMQ behaviour AMQP defaults to durable
    messages.
    kjnilsson committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    3c3ccb8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eb29656 View commit details
    Browse the repository at this point in the history