Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove delivery_mode header from AMQP 1.0 Shovel #10503

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

luos
Copy link
Contributor

@luos luos commented Feb 6, 2024

This header is not present if delivery_mode = 2, it does not really makes sense to leave it when delivery_mode = 1.
The durability of the message is reflected in the durable flag of the amqp 1.0 message.

Let me know what you think.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

This header is not present if delivery_mode = 2, it does not really
makes sense to leave it when delivery_mode = 1.
The durability of the message is reflected in the durable flag of the
amqp 1.0 message.
@michaelklishin
Copy link
Member

@luos why wasn't this submitted against main?

@luos
Copy link
Contributor Author

luos commented Feb 7, 2024

Hi, I've made the PR into 3.12.x because it is a follow up of #10037.

It can be submitted to main as well, I will do that.

@michaelklishin michaelklishin added this to the 3.12.13 milestone Feb 7, 2024
@luos
Copy link
Contributor Author

luos commented Feb 7, 2024

Moved to #10510

@luos luos closed this Feb 7, 2024
@luos luos reopened this Feb 7, 2024
@michaelklishin michaelklishin changed the title Remove delivery_mode header from amqp 1.0 shovel. Remove delivery_mode header from AMQP 1.0 Shovel Feb 7, 2024
@michaelklishin michaelklishin merged commit 068fe3f into rabbitmq:v3.12.x Feb 7, 2024
12 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants