Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistent query bug #483

Open
kjnilsson opened this issue Dec 5, 2024 · 0 comments
Open

consistent query bug #483

kjnilsson opened this issue Dec 5, 2024 · 0 comments
Labels
Milestone

Comments

@kjnilsson
Copy link
Contributor

Describe the bug

https://github.com/rabbitmq/ra-kv-store/actions/runs/12121409210

In. one test (in a long history of non failing runs) one leader in a minority partition decided it was ok to serve consistent reads.
After a fair bit of time investigating it wasn't clear exactly what caused it but I suspect it was due to the leader somehow ending up with an incorrectly high query_index for one of it's peers.

The consistent query logic can be refactored to avoid relying on this piece of state entirely as all it does is perform a leader liveness check then waits for the commit index to be appled then execute the query.

This check can be done without each member keeping a query_index and instead just returning the {term, index} tuple provided if the term is equal or higher.

Reproduction steps

https://github.com/rabbitmq/ra-kv-store/actions/runs/12121409210

Expected behavior

.

Additional context

No response

@kjnilsson kjnilsson added the bug label Dec 5, 2024
@kjnilsson kjnilsson added this to the 2.16.0 milestone Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant