Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve robustness across Atlantis models #38

Open
sgaichas opened this issue Mar 19, 2020 · 1 comment
Open

Improve robustness across Atlantis models #38

sgaichas opened this issue Mar 19, 2020 · 1 comment

Comments

@sgaichas
Copy link
Contributor

The run_truth function assumes a standardized "output" prefix in addition to the Atlantis "scenario" name. Now users specify Atlantis output file naming conventions and do not always use "output" as a prefix. Need to update all functions to remove assumption of prefix and have users supply the output naming convention.

Assumptions about the functional group .csv input file are also hard coded into some functions such as load_catch and load_bioind that filter on functional group characteristics. "IsFished" was a standard column that has a different case "isFished" in at least one model. Need to update these functions to find this column even with different cases in the name.

@sgaichas
Copy link
Contributor Author

run_truth in the annage branch no longer pastes "output"; the user must specify the full prefix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant