Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

474 optimize get r package usage #507

Merged
merged 5 commits into from
Oct 17, 2024
Merged

Conversation

maciekbanas
Copy link
Member

@maciekbanas maciekbanas commented Oct 17, 2024

Closes #474
Closes #494
Closes #395

… names to function, change name of the main parameter to `packages` and make the output more concise. The consequence of second feature was introduction of new parameter `output` instead of `raw_output` in private methods handling repositories responses.
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 77.63158% with 51 lines in your changes missing coverage. Please review.

Project coverage is 73.63%. Comparing base (5f28318) to head (498eb4e).
Report is 7 commits behind head on devel.

Files with missing lines Patch % Lines
R/GitHost.R 72.41% 24 Missing ⚠️
R/EngineRestGitLab.R 55.17% 13 Missing ⚠️
R/GitStats.R 84.05% 11 Missing ⚠️
R/gitstats_functions.R 0.00% 2 Missing ⚠️
R/EngineRestGitHub.R 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #507      +/-   ##
==========================================
+ Coverage   70.93%   73.63%   +2.69%     
==========================================
  Files          17       17              
  Lines        3069     3140      +71     
==========================================
+ Hits         2177     2312     +135     
+ Misses        892      828      -64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maciekbanas maciekbanas marked this pull request as ready for review October 17, 2024 08:41
Copy link
Collaborator

@Cotau Cotau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@maciekbanas maciekbanas merged commit e19f470 into devel Oct 17, 2024
8 checks passed
@maciekbanas maciekbanas deleted the 474-optimize-get_r_package_usage branch October 17, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants