Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

501 fix check token scopes #502

Merged
merged 15 commits into from
Oct 15, 2024
Merged

501 fix check token scopes #502

merged 15 commits into from
Oct 15, 2024

Conversation

maciekbanas
Copy link
Member

@maciekbanas maciekbanas commented Oct 14, 2024 •
edited
Loading

Closes #501

@maciekbanas
Fix check of token scopes and give more informative feedback when the…
e2767b6 
…y are not sufficient.
@maciekbanas
Skip and remove superfluous.
6daf6a9
@maciekbanas
Fix token check. The logic in set_default_token was wrong: if all p…
3b3072b 
…ossible tokens failed in for loop, no error was returned if last check token was not empty (but still invalid). This invalid token was passed to return (as it passed non-empty condition), with no message to user, but passing token to GitHost. Also, the check in GitHub `check_token_scopes` was wrong, and it is fixed now.
@maciekbanas
Fix when host is wrong. Check for wrong host was moved earlier, when …
7bfdf65 
…tokens are tested.
@maciekbanas
Try fix test after fixing check.
83ae94f
@maciekbanas
Lint.
c470433
@maciekbanas
Try fix tests on GHA.
3a26b74
@maciekbanas
Typo.
5636052
@maciekbanas
Try fix test on GHA.
accef8a
@maciekbanas
Fix job, try use tailored Github Pat.
eda6be3
@maciekbanas
Try fix checks (building vignettes). For checks, use token (set up as…
3159317 
… GHA secret) with wider scope than the default one on GHA.
@maciekbanas
Try use new token set up on GHA with wider scope.
f56d8d1
@codecov Codecov
Copy link

codecov bot commented Oct 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.30435% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.92%. Comparing base (7662271) to head (f53947e).
Report is 17 commits behind head on devel.

Files with missing lines Patch % Lines
R/GitHost.R 84.61% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##            devel     #502      +/-   ##
==========================================
+ Coverage   70.82%   70.92%   +0.10%     
==========================================
  Files          17       17              
  Lines        3047     3061      +14     
==========================================
+ Hits         2158     2171      +13     
- Misses        889      890       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maciekbanas maciekbanas self-assigned this Oct 15, 2024
@maciekbanas maciekbanas marked this pull request as ready for review October 15, 2024 08:02
@maciekbanas maciekbanas linked an issue Oct 15, 2024 that may be closed by this pull request
When token doesn't have required scope, code crashed with unformative error instead of error: #501
Closed
@maciekbanas maciekbanas merged commit 6768f63 into devel Oct 15, 2024
8 checks passed
@maciekbanas maciekbanas deleted the 501-fix-check-token-scopes branch October 15, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcinkowskak marcinkowskak marcinkowskak approved these changes

Assignees

@maciekbanas maciekbanas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When token doesn't have required scope, code crashed with unformative error instead of error:
2 participants
@maciekbanas @marcinkowskak