Add a dbQuoteLiteral method for logical class (#479)

Fixes #478
r-dbi · Nov 7, 2023 · 9c828cb · 9c828cb
1 parent 99a396e
commit 9c828cb
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 0 deletions.
diff --git a/NAMESPACE b/NAMESPACE
@@ -134,6 +134,7 @@ exportMethods(dbIsValid)
 exportMethods(dbListFields)
 exportMethods(dbListTables)
 exportMethods(dbQuoteIdentifier)
+exportMethods(dbQuoteLiteral)
 exportMethods(dbQuoteString)
 exportMethods(dbReadTable)
 exportMethods(dbRemoveTable)

diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,8 @@
 # bigrquery (development version)
 
+* Add a `dbQuoteLiteral()` method for logicals to revert breaking change 
+  introduced by DBI 1.1.2 (@meztez, #478).
+
 * bigrquery is now MIT licensed (#453).
 
 * Deprecated functions (i.e. those not starting with `bq_`) have been

diff --git a/R/dbi-connection.R b/R/dbi-connection.R
@@ -132,6 +132,16 @@ setMethod(
   }
 )
 
+#' @rdname DBI
+#' @export
+setMethod(
+  "dbQuoteLiteral", c("BigQueryConnection", "logical"),
+  function(conn, x, ...) {
+    x <- as.character(x)
+    x[is.na(x)] <- "NULL"
+    SQL(x, names = names(x))
+  }
+)
 
 #' @rdname DBI
 #' @inheritParams DBI::dbDataType

diff --git a/man/DBI.Rd b/man/DBI.Rd
diff --git a/tests/testthat/test-dbi-connection.R b/tests/testthat/test-dbi-connection.R
@@ -120,3 +120,11 @@ test_that("the return type of integer columns is set by the bigint argument", {
   expect_equal(DBI::dbGetQuery(con_integer64, sql)$x, bit64::as.integer64(x))
   expect_equal(DBI::dbGetQuery(con_character, sql)$x, x)
 })
+
+test_that("DBI::sqlData return TRUE, FALSE for logical class", {
+  con <- dbConnect(bigquery(), project = bq_test_project())
+  expect_equal(
+    DBI::dbQuoteLiteral(con, c(TRUE, FALSE, NA)),
+    DBI::SQL(c("TRUE", "FALSE", "NULL"))
+  )
+})