diff --git a/01_challenge/01_challenge.py b/01_challenge/01_challenge.py index 2d40fa5..f856397 100644 --- a/01_challenge/01_challenge.py +++ b/01_challenge/01_challenge.py @@ -24,7 +24,7 @@ def fizzbuzz(max_num): # % or modulo division gives you the remainder if i%num1==0 and i%num2==0: print(i,three_mul+five_mul) - elif i%num1=0: + elif i%num1==0: print(i,three_mul) elif i%num2==0: print(i,five_mul) diff --git a/01_challenge/01_readme.md b/01_challenge/01_readme.md index e69de29..892f687 100644 --- a/01_challenge/01_readme.md +++ b/01_challenge/01_readme.md @@ -0,0 +1 @@ +Fixed the first challenge \ No newline at end of file diff --git a/02_challenge/02_challenge.py b/02_challenge/02_challenge.py index b41cd50..4a2686d 100644 --- a/02_challenge/02_challenge.py +++ b/02_challenge/02_challenge.py @@ -23,4 +23,4 @@ def fizzbuzz(max_num): #----START OF SCRIPT if __name__=='__main__': - fizzbuzz() + fizzbuzz(9) diff --git a/02_challenge/02_readme.md b/02_challenge/02_readme.md index e69de29..84e390d 100644 --- a/02_challenge/02_readme.md +++ b/02_challenge/02_readme.md @@ -0,0 +1,2 @@ +Completed the task +while executing I should get either Fizz or Buzz, I am getting both result when I try with multiples of 3 or 5 diff --git a/03_challenge/03_challenge.py b/03_challenge/03_challenge.py index 6e67d1f..858684d 100644 --- a/03_challenge/03_challenge.py +++ b/03_challenge/03_challenge.py @@ -12,7 +12,7 @@ def fizzbuzz(max_num): "This method implements FizzBuzz" # Google for 'range in python' to see what it does - for i in range(1,max_num): + for i in range(55): # % or modulo division gives you the remainder if i%3==0 and i%5==0: print(i,"fizzbuzz") @@ -23,4 +23,4 @@ def fizzbuzz(max_num): #----START OF SCRIPT if __name__=='__main__': - fizzbuzz('16') + fizzbuzz('15') diff --git a/03_challenge/03_readme.md b/03_challenge/03_readme.md index e69de29..37c9e7e 100644 --- a/03_challenge/03_readme.md +++ b/03_challenge/03_readme.md @@ -0,0 +1,2 @@ +changed the string value to 55 from (1,max_num) +Task completed \ No newline at end of file diff --git a/04_challenge/04_challenge.py b/04_challenge/04_challenge.py index a3f5edf..7b46aac 100644 --- a/04_challenge/04_challenge.py +++ b/04_challenge/04_challenge.py @@ -23,11 +23,11 @@ def fizzbuzz(max_num): for i in range(1,max_num): # % or modulo division gives you the remainder if i%num1==0 and i%num2==0: - print(i,three_mul+five_mul) + print(i,"three_mul+five_mul") elif i%num1==0: - print(i,three_mul) + print(i,"three_mul") elif i%num2==0: - print(i,five_mul) + print("i,five_mul") #----START OF SCRIPT if __name__=='__main__': diff --git a/04_challenge/readme.md b/04_challenge/readme.md index e69de29..1adc70d 100644 --- a/04_challenge/readme.md +++ b/04_challenge/readme.md @@ -0,0 +1,2 @@ +aligned the line 26 print +completed the task \ No newline at end of file diff --git a/05_challenge/05_challenge.py b/05_challenge/05_challenge.py index 0f9bdbd..0c46b08 100644 --- a/05_challenge/05_challenge.py +++ b/05_challenge/05_challenge.py @@ -17,8 +17,8 @@ def fizzbuzz(max_num): # we will make our script 'tighter' in one of coming exercises three_mul = 'fizz' five_mul = 'buzz' - with open('mifile.txt','r') as f: - print 'i have created' + with open('myfile.txt','r') as f: + print ('i have created') num1 = int(f.readline()) num2=int(f.readline()) max_num = int(f.readline()) diff --git a/05_challenge/05_readme.md b/05_challenge/05_readme.md index e69de29..df3e8d6 100644 --- a/05_challenge/05_readme.md +++ b/05_challenge/05_readme.md @@ -0,0 +1,2 @@ +changed "myfile.txt" +entered paranthesis \ No newline at end of file diff --git a/06_challenge/06_challenge.py b/06_challenge/06_challenge.py index b09e24e..d8d4483 100644 --- a/06_challenge/06_challenge.py +++ b/06_challenge/06_challenge.py @@ -18,7 +18,7 @@ def fizzbuzz(max_num): three_mul = 'fizz' five_mul = 'buzz' num1 = conf.num1 - num2 = conf.num + num2 = conf.num2 # Google for 'range in python' to see what it does for i in range(1,max_num): # % or modulo division gives you the remainder diff --git a/06_challenge/06_readme.md b/06_challenge/06_readme.md index e69de29..a426eaf 100644 --- a/06_challenge/06_readme.md +++ b/06_challenge/06_readme.md @@ -0,0 +1,2 @@ +changed the num attribute to Num1 and Num2 +Task completed diff --git a/07_challenge/07_challenge.py b/07_challenge/07_challenge.py index dbe1bb1..f856397 100644 --- a/07_challenge/07_challenge.py +++ b/07_challenge/07_challenge.py @@ -31,4 +31,4 @@ def fizzbuzz(max_num): #----START OF SCRIPT if __name__=='__main__': - fizzbuzz(99) + fizzbuzz(100) diff --git a/07_challenge/07_readme.md b/07_challenge/07_readme.md index e69de29..6117af4 100644 --- a/07_challenge/07_readme.md +++ b/07_challenge/07_readme.md @@ -0,0 +1,2 @@ +Checked the challenge hint +verified the fizzbuzz string and changed to (100) \ No newline at end of file diff --git a/08_challenge/08_challenge.py b/08_challenge/08_challenge.py index a7147d2..71d3ebf 100644 --- a/08_challenge/08_challenge.py +++ b/08_challenge/08_challenge.py @@ -12,7 +12,7 @@ class Fizz_Buzz: "Class to implement FizzBuzz for multiples of 3 and 5" - def fizzbuzz(max_num): + def fizzbuzz(self, max_num): "This method implements FizzBuzz" # adding some redundant declarations on purpose diff --git a/08_challenge/08_readme.md b/08_challenge/08_readme.md index e69de29..728119e 100644 --- a/08_challenge/08_readme.md +++ b/08_challenge/08_readme.md @@ -0,0 +1 @@ +added self in def \ No newline at end of file diff --git a/09_challenge/09_challenge.py b/09_challenge/09_challenge.py index 37609a3..7c32124 100644 --- a/09_challenge/09_challenge.py +++ b/09_challenge/09_challenge.py @@ -20,7 +20,7 @@ def fizzbuzz(max_num): num2 = 5 # Google for 'range in python' to see what it does - for i in range(6,max_num): + for i in range(3,max_num): # % or modulo division gives you the remainder if i%num1==0 and i%num2==0: print(i,three_mul+five_mul) diff --git a/09_challenge/09_readme.md b/09_challenge/09_readme.md index e69de29..7554d28 100644 --- a/09_challenge/09_readme.md +++ b/09_challenge/09_readme.md @@ -0,0 +1,2 @@ +Changed the range to 3 +Hint helped me find the error \ No newline at end of file diff --git a/10_challenge/10_challenge.py b/10_challenge/10_challenge.py index 7d1edf8..f6a2121 100644 --- a/10_challenge/10_challenge.py +++ b/10_challenge/10_challenge.py @@ -8,7 +8,8 @@ # print buzz for multiples of 5 # print fizzbuzz for multiples of 3 and 5" """ -import fizzbuzz +from fizzbuzz import* + #----START OF SCRIPT if __name__=='__main__': diff --git a/12_challenge/12_challenge.py b/12_challenge/12_challenge.py index d8088be..1dc63d5 100644 --- a/12_challenge/12_challenge.py +++ b/12_challenge/12_challenge.py @@ -15,7 +15,7 @@ def __init__(self): # adding some redundant declarations on purpose # we will make our script 'tighter' in one of coming exercises self.num1 = 3 - self.num2 = 4 + self.num2 = 5 self.three_mul = 'fizz' self.five_mul = 'buzz'